git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Porting git to HP NonStop

From
Brandon Casey <drafnel@gmail.com>
Date
Aug 22, 2012, 18:38 UTC
Message-ID
<CA+sFfMdL=h=aoX7mCWfXJ+QvDLH7gvzWWo9HMXKSaTv+ykx-8w@mail.gmail.com>
In-Reply-To
<7vtxvu7p5s.fsf@alter.siamese.dyndns.org>
On Wed, Aug 22, 2012 at 11:33 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 56 quoted lines
> Brandon Casey <drafnel@gmail.com> writes:
>
>> Perhaps something like:
>>
>> diff --git a/usage.c b/usage.c
>> index a2a6678..2d0ff35 100644
>> --- a/usage.c
>> +++ b/usage.c
>> @@ -80,8 +80,15 @@ void NORETURN usage(const char *err)
>>
>>  void NORETURN die(const char *err, ...)
>>  {
>> +       static int dying;
>>         va_list params;
>>
>> +       if (dying) {
>> +               fputs("fatal: recursion detected in die handler\n", stderr);
>> +               exit(128);
>> +       }
>> +       dying = 1;
>> +
>>         va_start(params, err);
>>         die_routine(err, params);
>>         va_end(params);
>> @@ -89,11 +96,18 @@ void NORETURN die(const char *err, ...)
>>
>>  void NORETURN die_errno(const char *fmt, ...)
>>  {
>> +       static int dying;
>>         va_list params;
>>         char fmt_with_err[1024];
>>         char str_error[256], *err;
>>         int i, j;
>>
>> +       if (dying) {
>> +               fputs("fatal: recursion detected in die handler\n", stderr);
>> +               exit(128);
>> +       }
>> +       dying = 1;
>> +
>>         err = strerror(errno);
>>         for (i = j = 0; err[i] && j < sizeof(str_error) - 1; ) {
>>                 if ((str_error[j++] = err[i++]) != '%')
>
> With two function-scope static, you can go like this:
>
> die()
> -> die_routine()
>    -> xsomething()
>       -> die_errno()
>         -> die_routine()
>            -> xsomethingelse()
>               -> die() or die_errno()
>
> Not that we probably care too deeply about, as at least we won't
> infinitely recurse and die out of stack space.

Yeah, I noticed that, but didn't think it was important or likely. But there's no reason not to make "dying" a global.

-Brandon
Previous: Junio C HamanoNext: Joachim Schmitz
Message 28 of 39 in “RE: Porting git to HP NonStop”
  1. Joachim SchmitzAug 10, 2012
  2. Shawn PearceAug 10, 2012
  3. Joachim SchmitzAug 10, 2012
  4. Shawn PearceAug 10, 2012
  5. Joachim SchmitzAug 19, 2012
  6. Junio C HamanoAug 19, 2012
  7. Joachim SchmitzAug 20, 2012
  8. Junio C HamanoAug 20, 2012
  9. Joachim SchmitzAug 20, 2012
  10. Junio C HamanoAug 20, 2012
  11. Joachim SchmitzAug 22, 2012
  12. Brandon CaseyAug 22, 2012
  13. Brandon CaseyAug 22, 2012
  14. Joachim SchmitzAug 22, 2012
  15. Brandon CaseyAug 22, 2012
  16. Joachim SchmitzAug 22, 2012
  17. Junio C HamanoAug 22, 2012
  18. Joachim SchmitzAug 22, 2012
  19. Junio C HamanoAug 22, 2012
  20. Joachim SchmitzAug 22, 2012
  21. Johannes SixtAug 22, 2012
  22. Joachim SchmitzAug 22, 2012
  23. Johannes SixtAug 22, 2012
  24. Joachim SchmitzAug 22, 2012
  25. Brandon CaseyAug 22, 2012
  26. Brandon CaseyAug 22, 2012
  27. Junio C HamanoAug 22, 2012
  28. Brandon CaseyAug 22, 2012
  29. Joachim SchmitzAug 22, 2012
  30. Junio C HamanoAug 22, 2012
  31. Joachim SchmitzAug 22, 2012
  32. Junio C HamanoAug 22, 2012
  33. Joachim SchmitzAug 22, 2012
  34. Junio C HamanoAug 22, 2012
  35. Junio C HamanoAug 22, 2012
  36. Joachim SchmitzAug 10, 2012
  37. Johannes SixtAug 11, 2012
  38. Joachim SchmitzAug 14, 2012
  39. Junio C HamanoAug 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.