Re: Porting git to HP NonStop

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 19, 2012, 17:23 UTC
Message-ID: <7v628epzia.fsf@alter.siamese.dyndns.org>
In-Reply-To: <01a801cd7de8$b4c311a0$1e4934e0$@schmitz-digital.de>

"Joachim Schmitz" <jojo@schmitz-digital.de> writes:

Show 14 quoted lines

> Found the problem: our mkdir(dir,flags) fails with ENOENT when dir ends with
> a '/'.
> Not sure whether this us a bug on out platform or just allowed by POSIX and
> as such a wrong assumption in git though?
>
> [shortly after]
> A bit of googleing revealed that there is a GNUlib solution for this, which
> claims that at least NetBSD 1.5.2 has the same problem.
> (http://www.opensource.apple.com/source/gpatch/gpatch-2/patch/mkdir.c)
>
> And apparently this has been discussed on the git mailing list too, 2 years
> ago:
> http://lists-archives.com/git/728359-git-s-use-of-mkdir-2.html, there's a
> patch too.

Given that newer BSDs have fixed libc to accept directory name with a trailing slash, and that we use mkdir(2) in many places, I think the right way to do so is still what I suggested in that old thread in the last paragraph of my message

  http://thread.gmane.org/gmane.comp.version-control.git/155812/focus=155876

That is, have compat/tandem.c and define a replacement mkdir(2) in a way similar to how MinGW does so.

Show 18 quoted lines

> For now I've fixed it like this:
> /usr/local/bin/diff -EBbu ./builtin/init-db.c.orig ./builtin/init-db.c
> --- ./builtin/init-db.c.orig    2012-08-19 03:55:50 -0500
> +++ ./builtin/init-db.c 2012-08-19 03:39:57 -0500
> @@ -25,7 +25,16 @@
>
>  static void safe_create_dir(const char *dir, int share)
>  {
> +#ifdef __TANDEM /* our mkdir() can't cope with a trailing '/' */
> +       char mydir[PATH_MAX];
> +
> +       strcpy(mydir,dir);
> +       if (dir[strlen(dir)-1] == '/')
> +               mydir[strlen(dir)-1] = '\0';
> +       if (mkdir(mydir, 0777) < 0) {
> +#else
>         if (mkdir(dir, 0777) < 0) {
> +#endif

Move that part inside #ifdef __TANDEM to define

	int tandem_mkdir(const char *dir, mode_t mode)
        {
		...
	}

in your new file compat/tandem.c, add

	#ifdef __TANDEM
        #define mkdir(a,b) tandem_mkdir((a), (b))
	#endif

to git-compat-util.h and then add compat/tandem.o to COMPAT_OBJS in the top-level Makefile.

That way we do not have to keep an ugly platform specific ifdef in the very generic codepath.

Show 7 quoted lines

>                 if (errno != EEXIST) {
>                         perror(dir);
>                         exit(1);
>
>
>
> Bye, Jojo