RE: Porting git to HP NonStop

From: Joachim Schmitz <jojo@schmitz-digital.de>
Date: Aug 20, 2012, 16:09 UTC
Message-ID: <001801cd7eee$24f95a50$6eec0ef0$@schmitz-digital.de>
In-Reply-To: <7vy5l9lj6m.fsf@alter.siamese.dyndns.org>

Show 20 quoted lines

> From: Junio C Hamano [mailto:gitster@pobox.com]
> Sent: Monday, August 20, 2012 4:42 PM
> To: Joachim Schmitz
> Cc: 'Shawn Pearce'; git@vger.kernel.org; rsbecker@nexbridge.com
> Subject: Re: Porting git to HP NonStop
> 
> "Joachim Schmitz" <jojo@schmitz-digital.de> writes:
> 
> > OK, I'll go for a compat/mkdir.c though.
> 
> No.  See below.
> 
> > We shouldn't call it tandem.c as Tandem, the Company, doesn't exist
> > anymore and since more than a decade (bough by Compaq, then HP), only
> > the __TANDEM survived in our compiler and headers/libraries. Could
> > call it NonStop.c, but I don't really like that idea either, I'd
> > rather keep it more generic, just in case someone else might need it
> > too, or that issue someday gets fixed for NonStop.
> 
> compat/hp_nonstop.c is also fine, but I think matching "#ifdef __TANDEM"

is

> the most sensible.
> 
> And I wouldn't call it just "mkdir", as it is more likely than not that we

will find

> other incompatibilities that needs to be absorbed in the compat/ layer,

and we

> can add it to compat/tandem.c, but not to compat/mkdir.c, as that will be
> another nonstop specific tweak.

I haven't found any other to be needed. Well, poll, maybe, but with only minor tweaks for the win32 one works for me (and those tweaks are compatible with win32

Show 6 quoted lines

> A separate file, compat/tandem/mkdir.c, is fine, though.
> 
> > I'll go for git_mkdir(), similar to other git wrappers, (like for
> > mmap, pread, fopen, snprintf, vsnprintf, qsort).
> 
> Again, no.  Your breakage is that having underlying system mkdir that does

not

> understand trailing slash, which may not be specific to __TANDEM, but

still is

> _not_ the only possible mode of breakage.

Well, it is the only one GNUlib's mkdir caters for and I'd regard that an authoritative source...

> Squatting on a generic "git_mkdir()" name makes it harder for other people

to

> name their compat mkdir functions to tweak for the breakage on their
> platforms.  The examples you listed are all "the platform does not offer

it, so

> we implement the whole thing" kind, so it is in a different genre.

Nope, git_fopen() definitly is a wrapper for fopen(), as is git_vsnprintf() for vsnprintf().

Bye, Jojo