Re: [PATCH v2 06/10] sequencer.c: teach append_signoff how to detect duplicate s-o-b
On Tue, Jan 22, 2013 at 12:38 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 16 quoted lines
> Brandon Casey wrote:
>
>> Teach append_signoff how to detect a duplicate s-o-b in the commit footer.
>> This is in preparation to unify the append_signoff implementations in
>> log-tree.c and sequencer.c.
> [...]
>> --- a/sequencer.c
>> +++ b/sequencer.c
>> @@ -1082,9 +1101,10 @@ int sequencer_pick_revisions(struct replay_opts *opts)
>> return pick_commits(todo_list, opts);
>> }
>>
>> -void append_signoff(struct strbuf *msgbuf, int ignore_footer)
>> +void append_signoff(struct strbuf *msgbuf, int ignore_footer, int no_dup_sob)
>
> Isn't the behavior of passing '1' here just a bug in "format-patch -s"?
I think that is an open question.
Show 5 quoted lines
> Style: callers will be easier to read if the function takes a flag
> word with named bits, as in:
>
> #define APPEND_SIGNOFF_DEDUP (1 << 0)
> void append_signoff(..., int ignore_footer, unsigned flag)
Can't I just be lazy!!! Ok, you win. :b
-Brandon
Brandon Casey <drafnel@gmail.com>