[PATCH v2 01/10] sequencer.c: remove broken support for rfc2822 continuation in footer
- From
Brandon Casey <drafnel@gmail.com>
- Date
- Jan 21, 2013, 08:40 UTC
- Message-ID
- <1358757627-16682-2-git-send-email-drafnel@gmail.com>
- In-Reply-To
- <1358757627-16682-1-git-send-email-drafnel@gmail.com>
Commit c1e01b0c generalized the detection of the last paragraph signed-off-by footer and used rfc2822 as a guideline. Support for rfc2822 style continuation lines was also implemented, but not correctly, so it has never detected a line beginning with space or tab as a continuation of the previous line.
Since a commit message is not governed by the line length limits imposed by rfc2822 for email messages, and it does not seem like this functionality would produce "better" commit messages anyway, let's remove this broken functionality.
Signed-off-by: Brandon Casey <bcasey@nvidia.com> --- sequencer.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/sequencer.c b/sequencer.c index aef5e8a..fe25ef4 100644 --- a/sequencer.c +++ b/sequencer.c @@ -1027,7 +1027,6 @@ static int ends_rfc2822_footer(struct strbuf *sb, int ignore_footer) int hit = 0; int i, j, k; int len = sb->len - ignore_footer; - int first = 1; const char *buf = sb->buf; for (i = len - 1; i > 0; i--) { @@ -1044,11 +1043,6 @@ static int ends_rfc2822_footer(struct strbuf *sb, int ignore_footer) ; /* do nothing */ k++; - if ((buf[k] == ' ' || buf[k] == '\t') && !first) - continue; - - first = 0; - for (j = 0; i + j < len; j++) { ch = buf[i + j]; if (ch == ':')
-- 1.8.1.1.252.gdb33759