git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Unify appending signoff in format-patch, commit and sequencer

From
Brandon Casey <drafnel@gmail.com>
Date
Nov 15, 2012, 20:42 UTC
Message-ID
<CA+sFfMcfGbGDeXKZD1o4pmhbrJ1E5WgV3qrQBPT3eH=W54tNGw@mail.gmail.com>
In-Reply-To
<1352982778-28631-1-git-send-email-pclouds@gmail.com>
On Thu, Nov 15, 2012 at 4:32 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
Show 18 quoted lines
> There are two implementations of append_signoff in log-tree.c and
> sequencer.c, which do more or less the same thing. This patch
>
>  - teaches sequencer.c's append_signoff() not to append the signoff if
>    it's already there but not at the bottom
>
>  - removes log-tree.c's
>
>  - make sure "Signed-off-by: foo" in the middle of a line is not
>    counted as a sign off
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  Interestingly this patch triggers the fault that it fixes.
>  I was surprised that there was no blank line before my S-o-b
>  and thought I broke something. It turns out I used unmodified
>  format-patch and it mistook the S-o-b quote as true S-o-b line.
>  The modified one puts the blank line back.

Heh, yeah I noticed this bug yesterday when I submitted my changes affecting the same area of code (sequence.c). Glad I didn't waste too much time fixing it.

Have you looked at this:
   http://thread.gmane.org/gmane.comp.version-control.git/209781

That series doesn't duplicate your work, but the two series's should be resolved.

-Brandon
Previous: Nguyễn Thái Ngọc DuyNext: Nguyen Thai Ngoc Duy
Message 2 of 3 in “Unify appending signoff in format-patch, commit and sequencer”
  1. Unify appending signoff in format-patch, commit and sequencerNguyễn Thái Ngọc Duy, Nov 15, 2012
  2. Brandon CaseyNov 15, 2012
  3. Nguyen Thai Ngoc DuyNov 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.