From: Brandon Casey Date: Thu, 15 Nov 2012 20:42:41 GMT Subject: Re: [PATCH] Unify appending signoff in format-patch, commit and sequencer Message-ID: In-Reply-To: <1352982778-28631-1-git-send-email-pclouds@gmail.com> On Thu, Nov 15, 2012 at 4:32 AM, Nguyễn Thái Ngọc Duy wrote: > There are two implementations of append_signoff in log-tree.c and > sequencer.c, which do more or less the same thing. This patch > > - teaches sequencer.c's append_signoff() not to append the signoff if > it's already there but not at the bottom > > - removes log-tree.c's > > - make sure "Signed-off-by: foo" in the middle of a line is not > counted as a sign off > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > Interestingly this patch triggers the fault that it fixes. > I was surprised that there was no blank line before my S-o-b > and thought I broke something. It turns out I used unmodified > format-patch and it mistook the S-o-b quote as true S-o-b line. > The modified one puts the blank line back. Heh, yeah I noticed this bug yesterday when I submitted my changes affecting the same area of code (sequence.c). Glad I didn't waste too much time fixing it. Have you looked at this: http://thread.gmane.org/gmane.comp.version-control.git/209781 That series doesn't duplicate your work, but the two series's should be resolved. -Brandon