Re: [PATCH] Unify appending signoff in format-patch, commit and sequencer

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Nov 16, 2012, 04:13 UTC
Message-ID: <CACsJy8ABogKMujC9KhDeLXkwLpd0pkg03hqWzbH0Lmi0A7xoCA@mail.gmail.com>
In-Reply-To: <CA+sFfMcfGbGDeXKZD1o4pmhbrJ1E5WgV3qrQBPT3eH=W54tNGw@mail.gmail.com>

On Fri, Nov 16, 2012 at 3:42 AM, Brandon Casey <drafnel@gmail.com> wrote:

Show 16 quoted lines

>>  Interestingly this patch triggers the fault that it fixes.
>>  I was surprised that there was no blank line before my S-o-b
>>  and thought I broke something. It turns out I used unmodified
>>  format-patch and it mistook the S-o-b quote as true S-o-b line.
>>  The modified one puts the blank line back.
>
> Heh, yeah I noticed this bug yesterday when I submitted my changes
> affecting the same area of code (sequence.c).  Glad I didn't waste too
> much time fixing it.
>
> Have you looked at this:
>
>    http://thread.gmane.org/gmane.comp.version-control.git/209781
>
> That series doesn't duplicate your work, but the two series's should
> be resolved.

Thanks I'm watching that discussion now and probably will rebase on top of yours once it's finalized. I actually wrote this patch a while ago, just waiting for nd/builtin-to-libgit to graduate because of some linking issues this patch causes. I can wait a bit longer until yours graduates.

-- 
Duy