Re: [PATCH 2/2] prune.c: only print informational message in show_only or verbose mode

From: Brandon Casey <drafnel@gmail.com>
Date: Aug 7, 2012, 06:33 UTC
Message-ID: <CA+sFfMc28N2eKNa=GiKHvxOeN3u=-ruFQqTBz7cbCGX-G=TTgA@mail.gmail.com>
In-Reply-To: <20120807060311.GB13222@sigill.intra.peff.net>

On Mon, Aug 6, 2012 at 11:03 PM, Jeff King <peff@peff.net> wrote:

> On Mon, Aug 06, 2012 at 10:44:07PM -0700, Brandon Casey wrote:
>> Anyone else? :)
>
> Sorry to gang up on you. :)

Heh. :b

> I still think your 2/2 is worth doing independently, though. It is silly
> that git-prune will not mention pruned objects without "-v", but will
> mention temporary files. They should be in the same category.

As I mentioned in an earlier message, I think the original thinking was that removing a temporary object should be an unusual occurrence that indicates a failure of some sort, so you want to inform the user who may want to investigate (of course the file's gone, so what's to investigate). Removing a stale object file on the other hand is just part of the normal operation. That is why the former is always printed out and the latter only when -v is used.

That was the original thinking, but I don't think it matters very much. Printing both using the same conditions seems valid. My commit message should be scrapped and replaced with something like your paragraph though..

-Brandon