git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] prune.c: only print informational message in show_only or verbose mode

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 7, 2012, 15:41 UTC
Message-ID
<7vhasewvy6.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CA+sFfMc28N2eKNa=GiKHvxOeN3u=-ruFQqTBz7cbCGX-G=TTgA@mail.gmail.com>
Brandon Casey <drafnel@gmail.com> writes:
Show 19 quoted lines
> On Mon, Aug 6, 2012 at 11:03 PM, Jeff King <peff@peff.net> wrote:
>> On Mon, Aug 06, 2012 at 10:44:07PM -0700, Brandon Casey wrote:
>>> Anyone else? :)
>>
>> Sorry to gang up on you. :)
>
> Heh. :b
>
>> I still think your 2/2 is worth doing independently, though. It is silly
>> that git-prune will not mention pruned objects without "-v", but will
>> mention temporary files. They should be in the same category.
>
> As I mentioned in an earlier message, I think the original thinking
> was that removing a temporary object should be an unusual occurrence
> that indicates a failure of some sort, so you want to inform the user
> who may want to investigate (of course the file's gone, so what's to
> investigate).  Removing a stale object file on the other hand is just
> part of the normal operation.  That is why the former is always
> printed out and the latter only when -v is used.

That matches my understanding, modulo "may want to investigate" is probably more like "may want to be reminded of an earlier repack that was aborted".

> That was the original thinking, but I don't think it matters very
> much.  Printing both using the same conditions seems valid.

Yeah, I agree that it does not make much difference either way and both ways of thinking feel equally valid.

Previous: Brandon CaseyNext: Junio C Hamano
Message 11 of 15 in “Did we break receive-pack recently?”
  1. Junio C HamanoAug 5, 2012
  2. Brandon CaseyAug 6, 2012
  3. Brandon CaseyAug 6, 2012
  4. 1/2 t/t5400: demonstrate breakage caused by informational message from pruneBrandon Casey, Aug 7, 2012
  5. 2/2 prune.c: only print informational message in show_only or verbose modeBrandon Casey, Aug 7, 2012
  6. Junio C HamanoAug 7, 2012
  7. Junio C HamanoAug 7, 2012
  8. Brandon CaseyAug 7, 2012
  9. Jeff KingAug 7, 2012
  10. Brandon CaseyAug 7, 2012
  11. Junio C HamanoAug 7, 2012
  12. Junio C HamanoAug 7, 2012
  13. Jeff KingAug 7, 2012
  14. Brandon CaseyAug 7, 2012
  15. Jeff KingAug 7, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.