git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] prune.c: only print informational message in show_only or verbose mode

From
Jeff King <peff@peff.net>
Date
Aug 7, 2012, 06:03 UTC
Message-ID
<20120807060311.GB13222@sigill.intra.peff.net>
In-Reply-To
<CA+sFfMdVhTwAFLUgrO-mLBh8apG-5X1OJKCN9xgq3-N+1RBrvg@mail.gmail.com>
On Mon, Aug 06, 2012 at 10:44:07PM -0700, Brandon Casey wrote:
Show 9 quoted lines
> On Mon, Aug 6, 2012 at 10:32 PM, Jeff King <peff@peff.net> wrote:
> >
> > This seems like a band-aid. The real problem is that auto-gc can
> > interfere with the pack protocol, which it should not be allowed to do,
> > no matter what it produces.
> >
> > We could fix that root cause with this patch (on top of your 1/2):
> 
> Anyone else? :)
Sorry to gang up on you. :)

I still think your 2/2 is worth doing independently, though. It is silly that git-prune will not mention pruned objects without "-v", but will mention temporary files. They should be in the same category.

-Peff
Previous: Brandon CaseyNext: Brandon Casey
Message 9 of 15 in “Did we break receive-pack recently?”
  1. Junio C HamanoAug 5, 2012
  2. Brandon CaseyAug 6, 2012
  3. Brandon CaseyAug 6, 2012
  4. 1/2 t/t5400: demonstrate breakage caused by informational message from pruneBrandon Casey, Aug 7, 2012
  5. 2/2 prune.c: only print informational message in show_only or verbose modeBrandon Casey, Aug 7, 2012
  6. Junio C HamanoAug 7, 2012
  7. Junio C HamanoAug 7, 2012
  8. Brandon CaseyAug 7, 2012
  9. Jeff KingAug 7, 2012
  10. Brandon CaseyAug 7, 2012
  11. Junio C HamanoAug 7, 2012
  12. Junio C HamanoAug 7, 2012
  13. Jeff KingAug 7, 2012
  14. Brandon CaseyAug 7, 2012
  15. Jeff KingAug 7, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.