git/list[1] front-page[2] threads[3] people[4] search[5] about
 

git send-email Cc with cruft not working as expected

From
Jacob Keller <jacob.keller@gmail.com>
Date
Aug 22, 2017, 23:15 UTC
Message-ID
<CA+P7+xrtZYUjPcVMkA+x8B57w+LxjjU8YSKcE77DrWne7449rg@mail.gmail.com>
Hi,

I recently found an issue with git-send-email where it does not properly remove the cruft of an email address when sending using a Cc: line.

The specific example is with a commit containing the following Cc line,
Cc: stable@vger.kernel.org # 4.10+

which is the standard way Linux upstream expects the stable Ccs to be, and I saw several examples of this in the past.

However, this gets converted into a cc of "stable@vger.kernel.org#4.10+" which isn't a valid address obviously.

This does work as expected if you remember to
Cc: <stable@vger.kernel.org> # 4.10+

I would have assumed that validate_address would kick in and let me know that the address I'd given isn't valid, or something along those lines.

I tried to come up with a test for this, but modifying t9001 seemed to cause other failures and I couldn't detangle exactly how the tests fit together.

Is this simply expected behavior and I need to remember to use <> around the address?

Thanks, Jake

Next: Stefan Beller
Message 1 of 13 in “git send-email Cc with cruft not working as expected”
  1. Jacob KellerAug 22, 2017
  2. Stefan BellerAug 22, 2017
  3. Jacob KellerAug 22, 2017
  4. Stefan BellerAug 22, 2017
  5. Matthieu MoyAug 23, 2017
  6. 1/2 send-email: fix garbage removal after addressMatthieu Moy, Aug 23, 2017
  7. 2/2 send-email: don't use Mail::Address, even if availableMatthieu Moy, Aug 23, 2017
  8. Jacob KellerAug 23, 2017
  9. Junio C HamanoAug 24, 2017
  10. Matthieu MoyAug 25, 2017
  11. 1/2 send-email: fix garbage removal after addressMatthieu Moy, Aug 25, 2017
  12. 2/2 send-email: don't use Mail::Address, even if availableMatthieu Moy, Aug 25, 2017
  13. Jacob KellerAug 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.