git send-email Cc with cruft not working as expected
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Aug 22, 2017, 23:15 UTC
- Message-ID
- <CA+P7+xrtZYUjPcVMkA+x8B57w+LxjjU8YSKcE77DrWne7449rg@mail.gmail.com>
Hi,
I recently found an issue with git-send-email where it does not properly remove the cruft of an email address when sending using a Cc: line.
The specific example is with a commit containing the following Cc line,
Cc: stable@vger.kernel.org # 4.10+
which is the standard way Linux upstream expects the stable Ccs to be, and I saw several examples of this in the past.
However, this gets converted into a cc of "stable@vger.kernel.org#4.10+" which isn't a valid address obviously.
This does work as expected if you remember to
Cc: <stable@vger.kernel.org> # 4.10+
I would have assumed that validate_address would kick in and let me know that the address I'd given isn't valid, or something along those lines.
I tried to come up with a test for this, but modifying t9001 seemed to cause other failures and I couldn't detangle exactly how the tests fit together.
Is this simply expected behavior and I need to remember to use <> around the address?
Thanks, Jake