git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git send-email Cc with cruft not working as expected

From
Jacob Keller <jacob.keller@gmail.com>
Date
Aug 23, 2017, 22:49 UTC
Message-ID
<CA+P7+xp7Gr_zvsreXpLLkn7GsR2fh-0W-20ov4QonQ7c292utA@mail.gmail.com>
In-Reply-To
<vpqo9r6lhzq.fsf@anie.imag.fr>
On Wed, Aug 23, 2017 at 3:02 AM, Matthieu Moy <git@matthieu-moy.fr> wrote:
Show 8 quoted lines
>> On Tue, Aug 22, 2017 at 4:30 PM, Jacob Keller <jacob.keller@gmail.com> wrote:
>>> Additionally I just discovered that the behavior here changes pretty
>>> drastically if you have Email::Validate installed, now it splits the
>>> address into multiple things:
>
> (I'm assuming you mean Email::Address, there's also Email::Valid but I
> don't think it would modify the behavior)
>

No I actually definitely meant Email::Valid. I already had Mail::Address installed, and I then installed Email::Valid, and it changed behavior to split the cruft into multiple addresses.

I don't actually know why or how it did this, but I'm certain it was presence of Email::Valid that did it.

However, your first patch addresses the issue since you remove the cruft well before passing it into Email::Valid anyways.

> Hmm, I think we reached the point where we should just stop using
> Email::Address.
I do agree, I don't think we should use Mail::Address.
Show 6 quoted lines
>
> Patch series follows and should address both points.
>
> --
> Matthieu Moy
> http://matthieu-moy.fr
Previous: Matthieu Moy
Message 13 of 13 in “git send-email Cc with cruft not working as expected”
  1. Jacob KellerAug 22, 2017
  2. Stefan BellerAug 22, 2017
  3. Jacob KellerAug 22, 2017
  4. Stefan BellerAug 22, 2017
  5. Matthieu MoyAug 23, 2017
  6. 1/2 send-email: fix garbage removal after addressMatthieu Moy, Aug 23, 2017
  7. 2/2 send-email: don't use Mail::Address, even if availableMatthieu Moy, Aug 23, 2017
  8. Jacob KellerAug 23, 2017
  9. Junio C HamanoAug 24, 2017
  10. Matthieu MoyAug 25, 2017
  11. 1/2 send-email: fix garbage removal after addressMatthieu Moy, Aug 25, 2017
  12. 2/2 send-email: don't use Mail::Address, even if availableMatthieu Moy, Aug 25, 2017
  13. Jacob KellerAug 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.