Re: [RFC PATCH 1/2] send-email: fix garbage removal after address
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Aug 23, 2017, 21:59 UTC
- Message-ID
- <CA+P7+xrUgC9M9VeZTKL4K=ro23arrWHL+F5YUUTj_ZU8t24kkg@mail.gmail.com>
- In-Reply-To
- <20170823102102.20120-1-git@matthieu-moy.fr>
On Wed, Aug 23, 2017 at 3:21 AM, Matthieu Moy <git@matthieu-moy.fr> wrote:
Show 23 quoted lines
> This is a followup over 9d33439 (send-email: only allow one address > per body tag, 2017-02-20). The first iteration did allow writting > > Cc: <foo@example.com> # garbage > > but did so by matching the regex ([^>]*>?), i.e. stop after the first > instance of '>'. However, it did not properly deal with > > Cc: foo@example.com # garbage > > Fix this using a new function strip_garbage_one_address, which does > essentially what the old ([^>]*>?) was doing, but dealing with more > corner-cases. Since we've allowed > > Cc: "Foo # Bar" <foobar@example.com> > > in previous versions, it makes sense to continue allowing it (but we > still remove any garbage after it). OTOH, when an address is given > without quoting, we just take the first word and ignore everything > after. > > Signed-off-by: Matthieu Moy <git@matthieu-moy.fr> > ---
I pulled this and tested it for my issue, and it fixes the problem for me. I think the approach in the code was solid too, extracting out the logic helps make the code more clear.
Thanks, Jake