Re: [PATCH 1/2] notes: don't expand qualified refs in expand_notes_ref
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Sep 22, 2015, 06:50 UTC
- Message-ID
- <CA+P7+xpv_0Sf94FqMKJa0v0pSSEWXPRD2KQ0kmNBKC=2hrunhw@mail.gmail.com>
- In-Reply-To
- <xmqqzj0mkn7r.fsf@gitster.mtv.corp.google.com>
On Wed, Sep 16, 2015 at 3:34 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> Jacob Keller <jacob.e.keller@intel.com> writes: > >> From: Jacob Keller <jacob.keller@gmail.com> >> >> The documentation for --refs says that it will treat unqualified refs as >> under refs/notes. Current behavior is to prefix refs/notes to all >> strings that do not start with refs/notes or notes/, resulting in >> performing actions on refs such as "refs/notes/refs/foo/bar" instead of >> attempting to perform actions on "refs/foo/bar". > > That actually sounds like a sensible thing to do, if you replace > 'foo' with 'heads', for example, i.e. refs/notes/refs/heads/bar is a > notes about commits reachable from the branch whose name is 'bar'. > > So given "refs/heads/bar", which is unqualified in the context of > talking about references that hold notes trees, the current > behaviour to turn it into "refs/notes/refs/heads/bar" is very > sensible, I would think. >
I never got any better suggestion on how to allow the behavior desired, which is to enable merging from a non-notes location, in order to provide a standard location for remote notes, ie: refs/remote-notes/<remote>/<ref>
Any suggestions, if you're against this particular change?
Regards, Jake