git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] notes: allow read only notes actions on refs outside of refs/notes

From
Jacob Keller <jacob.e.keller@intel.com>
Date
Sep 16, 2015, 22:06 UTC
Message-ID
<1442441194-5506-1-git-send-email-jacob.e.keller@intel.com>
From: Jacob Keller <jacob.keller@gmail.com>

The primary purpose of this series is to allow fetching remote notes into a namespace such as "refs/remote-notes/<remote>/foo". Currently, git-notes refuses to operate on refs outside of refs/notes/* including merging from them, listing or showing them. This makes it difficult to share notes from a remote repository.

Fix expand_notes_ref to not always prepend refs/notes to fully qualified refs. Allow git-notes actions which do not specify NOTES_INIT_WRITABLE to be performed on refs outside of refs/notes/*

Future work will include more coupling of "refs/remote-notes/<remote>" into git-notes so that you can specify refs as "<remote>/foo" similar to how remotes work for branches.

In addition, long term goal is to make it default to fetch notes into refs/remote-notes/<remote>/*, and possibly to add some status for tracking similar to how tracking branches work.

The one downside currently is that a test case for prevention of merge from "refs/heads/master" had to be removed as "git notes merge refs/heads/master" now works. I am not sure how this could be fixed.. I did not find any way to tell if a treeish actually was a notes tree or not...

This topic depends on mh/notes-allow-reading-treeish and actually expands what this topic allowed before. Previously, treeishes such as notes@{1} were made allowable, but the ref still had to be found under refs/notes.

No documentation changes were made as from the looks of it, documentation for --ref and core.notesRef is already correct despite the previous behavior of expand_notes_ref. In that sense, documentation was wrong before.

Jacob Keller (2):
  notes: don't expand qualified refs in expand_notes_ref
  notes: allow non-writable actions on refs outside of refs/notes
 builtin/notes.c        | 11 ++++++-----
 notes.c                |  4 ++--
 t/t3308-notes-merge.sh |  1 -
 3 files changed, 8 insertions(+), 8 deletions(-)
-- 
2.6.0.rc2.248.g5b5be23
Next: Jacob Keller
Message 1 of 13 in “notes: allow read only notes actions on refs outside of refs/notes”
  1. 0/2 notes: allow read only notes actions on refs outside of refs/notesJacob Keller, Sep 16, 2015
  2. 1/2 notes: don't expand qualified refs in expand_notes_refJacob Keller, Sep 16, 2015
  3. Junio C HamanoSep 16, 2015
  4. Jacob KellerSep 16, 2015
  5. Jacob KellerSep 22, 2015
  6. Junio C HamanoSep 22, 2015
  7. Jacob KellerSep 22, 2015
  8. Jacob KellerSep 22, 2015
  9. Junio C HamanoSep 22, 2015
  10. Jacob KellerSep 22, 2015
  11. 2/2 notes: allow non-writable actions on refs outside of refs/notesJacob Keller, Sep 16, 2015
  12. Mike HommeySep 16, 2015
  13. Jacob KellerSep 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.