Re: [RFC 3/3] refspec: add support for negative refspecs

From: Jacob Keller <jacob.keller@gmail.com>
Date: Aug 21, 2020, 16:28 UTC
Message-ID: <CA+P7+xpc_jOc5kQ3eicSGUEO+GSr9a3fZ6TUyeEPvy+YSVdGNg@mail.gmail.com>
In-Reply-To: <xmqqr1s09djt.fsf@gitster.c.googlers.com>

On Fri, Aug 21, 2020 at 9:19 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

>
> Jeff King <peff@peff.net> writes:
>
> > Yes, I'd agree we should be applying the negative refspecs first, and
> > then de-duping / looking for collisions. Which I think is what the patch
> > is doing currently.
>
> Good to see that we thought this through.  The reasoning deserves to
> be recorded somewhere (perhaps a comment just before making the call
> to apply the negative refspec).
>
> Thanks.

I am hoping to add a test case for this as well!