Re: [PATCH 2/2] xdiff: implement empty line chunk heuristic

From: Jacob Keller <jacob.keller@gmail.com>
Date: Apr 29, 2016, 20:59 UTC
Message-ID: <CA+P7+xpFCBU1xYbtcX8jtmDDyY8p0CiJJ=bexTmi=_vwWRZi0Q@mail.gmail.com>
In-Reply-To: <xmqqa8kcxip9.fsf@gitster.mtv.corp.google.com>

On Fri, Apr 29, 2016 at 1:29 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> ... Having the two directly next to each other reads
>> better to me. This is a pretty unusual diff, though, in that it did
>> change the surrounding whitespace (and if you look further in the diff,
>> the identical change is made elsewhere _without_ touching the
>> whitespace). So this is kind of an anomaly. And IMHO the weirdness here
>> is outweighed by the vast number of improvements elsewhere.
>
> So... is everybody happy with the result and now we can drop the
> tweaking knob added to help experimentation before merging the
> result to 'master'?
>
> I am pretty happy with the end result myself.

I am very happy with it. I haven't had any issues, and I think we'll find better traction by enabling it at this point and seeing when/if someone complains.

I think for most it won't be noticed and for those that do it will likely be positive.

Thanks, Jake