git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC for GIT] pull-request: add praise to people doing QA

From
Jacob Keller <jacob.keller@gmail.com>
Date
Jan 16, 2017, 04:05 UTC
Message-ID
<CA+P7+xojtk4QD2rtAy90ytHCpuaSAOy2SE-aXC4A863N020Efw@mail.gmail.com>
In-Reply-To
<xmqqlgubc04z.fsf@gitster.mtv.corp.google.com>
On Sun, Jan 15, 2017 at 4:35 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> As to the implementation, I am wondering if we can make this somehow
> work well with the "trailers" code we already have, instead of
> inventing yet another parser of trailers.
>
> In its current shape, "interpret-trailers" focuses on "editing" an
> existing commit log message to tweak the trailer lines.  That mode
> of operation would help amending and rebasing, and to do that it
> needs to parse the commit log message, identify trailer blocks,
> parse out each trailer lines, etc.
>
> There is no fundamental reason why its output must be an edited
> original commit log message---it should be usable as a filter that
> picks trailer lines of the selected trailer type, like "Tested-By",
> etc.

I have been looking at ways to use the interpret-trailers as a way to filter commits and print out trailers, and this sort of feature would be useful to me if it were generic. (and then pull-request could use the generic interface to grab the data and then parse it into a praise format)

Thanks, Jake

Previous: Junio C HamanoNext: Wolfram Sang
Message 3 of 10 in “[RFC for GIT] pull-request: add praise to people doing QA”
  1. Wolfram SangJan 15, 2017
  2. Junio C HamanoJan 16, 2017
  3. Jacob KellerJan 16, 2017
  4. Wolfram SangJan 19, 2017
  5. Junio C HamanoJan 19, 2017
  6. Wolfram SangJan 19, 2017
  7. Jeff KingJan 19, 2017
  8. Jacob KellerJan 19, 2017
  9. Joe PerchesJan 20, 2017
  10. Jacob KellerJan 20, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.