git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC for GIT] pull-request: add praise to people doing QA

From
Jeff King <peff@peff.net>
Date
Jan 19, 2017, 21:20 UTC
Message-ID
<20170119212039.3gixsrk7qco45wjo@sigill.intra.peff.net>
In-Reply-To
<20170119204343.xtotmjddhbum2mvr@ninjato>
On Thu, Jan 19, 2017 at 09:43:45PM +0100, Wolfram Sang wrote:
Show 24 quoted lines
> > As to the implementation, I am wondering if we can make this somehow
> > work well with the "trailers" code we already have, instead of
> > inventing yet another parser of trailers.  
> > 
> > In its current shape, "interpret-trailers" focuses on "editing" an
> > existing commit log message to tweak the trailer lines.  That mode
> > of operation would help amending and rebasing, and to do that it
> > needs to parse the commit log message, identify trailer blocks,
> > parse out each trailer lines, etc.  
> > 
> > There is no fundamental reason why its output must be an edited
> > original commit log message---it should be usable as a filter that
> > picks trailer lines of the selected trailer type, like "Tested-By",
> > etc.
> 
> I didn't know about trailers before. As I undestand it, I could use
> "Tested-by" as the key, and the commit subject as the value. This list
> then could be parsed and brought into proper output shape. It would
> simplify the subject parsing, but most things my AWK script currently
> does would still need to stay or to be reimplemented (extracting names
> from tags, creating arrays of tags given by $name). Am I correct?
> 
> All under the assumption that trailers work on a range of commits. I
> have to admit that adding this to git is beyond my scope.

This sounds a lot like the shortlog-trailers work I did about a year ago:

  http://public-inbox.org/git/20151229073832.GN8842@sigill.intra.peff.net/
  http://public-inbox.org/git/20151229075013.GA9191@sigill.intra.peff.net/
Nobody seemed to really find it useful, so I didn't pursue it.

Some of the preparatory patches in that series bit-rotted in the meantime, but you can play with a version based on v2.7.0 by fetching the "shortlog-trailers-historical" branch from https://github.com/peff/git.git.

And then things like:
  git shortlog --ident=tested-by --format='...tested a patch by %an'

work (and you can put whatever commit items you want into the --format, including just dumping the hash if you want to do more analysis).

-Peff
Previous: Wolfram SangNext: Jacob Keller
Message 7 of 10 in “[RFC for GIT] pull-request: add praise to people doing QA”
  1. Wolfram SangJan 15, 2017
  2. Junio C HamanoJan 16, 2017
  3. Jacob KellerJan 16, 2017
  4. Wolfram SangJan 19, 2017
  5. Junio C HamanoJan 19, 2017
  6. Wolfram SangJan 19, 2017
  7. Jeff KingJan 19, 2017
  8. Jacob KellerJan 19, 2017
  9. Joe PerchesJan 20, 2017
  10. Jacob KellerJan 20, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.