Re: [RFC for GIT] pull-request: add praise to people doing QA

From: Wolfram Sang <wsa@the-dreams.de>
Date: Jan 19, 2017, 20:43 UTC
Message-ID: <20170119204343.xtotmjddhbum2mvr@ninjato>
In-Reply-To: <xmqqlgubc04z.fsf@gitster.mtv.corp.google.com>

Show 5 quoted lines

> So the idea is to have list of those whose names appear on
> Reviewed-by: and Tested-by: collected and listed after the list of
> commit titles and author names.  I personally do not see much
> downsides in doing so, but I do not consume that many PRs myself, so
> let's hear from those who actually do process many of them.

Sadly, no further responses so far. Let's see if they will come if I keep posting my pull requests with that information attached.

Show 14 quoted lines

> As to the implementation, I am wondering if we can make this somehow
> work well with the "trailers" code we already have, instead of
> inventing yet another parser of trailers.  
> 
> In its current shape, "interpret-trailers" focuses on "editing" an
> existing commit log message to tweak the trailer lines.  That mode
> of operation would help amending and rebasing, and to do that it
> needs to parse the commit log message, identify trailer blocks,
> parse out each trailer lines, etc.  
> 
> There is no fundamental reason why its output must be an edited
> original commit log message---it should be usable as a filter that
> picks trailer lines of the selected trailer type, like "Tested-By",
> etc.

I didn't know about trailers before. As I undestand it, I could use "Tested-by" as the key, and the commit subject as the value. This list then could be parsed and brought into proper output shape. It would simplify the subject parsing, but most things my AWK script currently does would still need to stay or to be reimplemented (extracting names from tags, creating arrays of tags given by $name). Am I correct?

All under the assumption that trailers work on a range of commits. I have to admit that adding this to git is beyond my scope.

Thanks for looking into it,

   Wolfram