Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak
- From
Elia Pinto <gitter.spiros@gmail.com>
- Date
- Oct 8, 2012, 13:19 UTC
- Message-ID
- <CA+EOSBnKqkQ_nLyEKzxsMYnB04X9ABMp3P3CuDy3ohfcoEbQtA@mail.gmail.com>
- In-Reply-To
- <7vbogfquc8.fsf@alter.siamese.dyndns.org>
2012/10/6 Junio C Hamano <gitster@pobox.com>:
Show 21 quoted lines
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes: > >> The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK >> variable, either from the environment or command line of an >> 'make test' invocation. In order to allow the malloc checks to be >> disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK >> to the environment using an export directive. > > We would want to encourage people to test with cheap but effective > checks when available. I do not see "malloc: using debugging hooks" > message anywhere when I run tests, but if you do, I'd rather see us > check if we can tell glibc to stop doing so first without disabling > the whole test. Your patch feels like the first step to a slipperly > slope whose destination would make us say "we get too many messages > so let's do nothing in "make test" with this configuration." when > taken to the extreme, and obviously we would not want to go there > ;-). > > Elia, you brought the MALLOC_CHECK_ up. Did you hear about this > issue elsewhere before, and if you did, do you know how other > projects solves it?
Ok. I have found. For me this is not a problem any more these days. Was fixed in glibc 2.8.90-9 2008
* Wed Jul 16 2008 Jakub Jelinek <jakub@redhat.com> 2.8.90-9 - update from trunk - fix unbuffered vfprintf if writing to the stream fails (#455360) - remove useless "malloc: using debugging hooks" message (#455355) - nscd fixes (from glibc rpm changelog)
This is the bugzilla filled and closed https://bugzilla.redhat.com/show_bug.cgi?id=455355
Ramsay, what version of glibc you have and in what distro? thanks