git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 6, 2012, 19:22 UTC
Message-ID
<7vbogfquc8.fsf@alter.siamese.dyndns.org>
In-Reply-To
<50706B54.8090004@ramsay1.demon.co.uk>
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
Show 5 quoted lines
> The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
> variable, either from the environment or command line of an
> 'make test' invocation. In order to allow the malloc checks to be
> disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
> to the environment using an export directive.

We would want to encourage people to test with cheap but effective checks when available. I do not see "malloc: using debugging hooks" message anywhere when I run tests, but if you do, I'd rather see us check if we can tell glibc to stop doing so first without disabling the whole test. Your patch feels like the first step to a slipperly slope whose destination would make us say "we get too many messages so let's do nothing in "make test" with this configuration." when taken to the extreme, and obviously we would not want to go there ;-).

Elia, you brought the MALLOC_CHECK_ up. Did you hear about this issue elsewhere before, and if you did, do you know how other projects solves it?

Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK to your environment before running "make test" suffice?

Previous: Ramsay JonesNext: Elia Pinto
Message 2 of 11 in “MALLOC_CHECK: Allow checking to be disabled from config.mak”
  1. MALLOC_CHECK: Allow checking to be disabled from config.makRamsay Jones, Oct 6, 2012
  2. Junio C HamanoOct 6, 2012
  3. Elia PintoOct 7, 2012
  4. Elia PintoOct 8, 2012
  5. Christian CouderOct 9, 2012
  6. Ramsay JonesOct 10, 2012
  7. Ramsay JonesOct 10, 2012
  8. Elia PintoOct 10, 2012
  9. Elia PintoOct 10, 2012
  10. Junio C HamanoOct 10, 2012
  11. Ramsay JonesOct 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.