threads / patch / 31742

patchMALLOC_CHECK: Allow checking to be disabled from config.mak

Subject: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

## tl;dr

11 messages between Oct 6, 2012 and Oct 11, 2012. Diffs are folded; open one to read it.

replies: 10people: 4as markdown or json

Ramsay Jones· Oct 6, 2012, 17:33 UTC · lore

The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK variable, either from the environment or command line of an 'make test' invocation. In order to allow the malloc checks to be disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK to the environment using an export directive.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Junio,

Now that the malloc checks have been enabled, running the tests has become somewhat noisy with "malloc: using debugging hooks" messages spewing continuously to the terminal. [I usually run the tests like so:

    ramsay$ time $(make test >test-out 2>&1)
    malloc: using debugging hooks
    malloc: using debugging hooks
    ...
    malloc: using debugging hooks
    real    16m11.408s
    user    5m17.412s
    sys     4m54.786s
    ramsay$ 
]
strace tells me that the controlling terminal, /dev/tty, is being
opened directly in order to write these messages. I find this
annoying, so I tried to disable the malloc checks from config.mak ...

Note that I decided not to write the TEST_NO_MALLOC_CHECK setting to the GIT-BUILD-OPTIONS file, since I prefer to enable/disable the malloc checks myself when running the test script directly.

ATB, Ramsay Jones

 Makefile | 1 +
 1 file changed, 1 insertion(+)
Show changes to Makefile +1 −0
diff --git a/Makefile b/Makefile
index 8413606..f69979e 100644
--- a/Makefile
+++ b/Makefile
@@ -2636,6 +2636,7 @@ bin-wrappers/%: wrap-for-bin.sh
 # with that.
 
 export NO_SVN_TESTS
+export TEST_NO_MALLOC_CHECK
 
 ### Testing rules
 

-- 
1.7.12
Junio C Hamano· Oct 6, 2012, 19:22 UTC · re: Ramsay Jones · lore

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
Show 5 quoted lines
> The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
> variable, either from the environment or command line of an
> 'make test' invocation. In order to allow the malloc checks to be
> disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
> to the environment using an export directive.

We would want to encourage people to test with cheap but effective checks when available. I do not see "malloc: using debugging hooks" message anywhere when I run tests, but if you do, I'd rather see us check if we can tell glibc to stop doing so first without disabling the whole test. Your patch feels like the first step to a slipperly slope whose destination would make us say "we get too many messages so let's do nothing in "make test" with this configuration." when taken to the extreme, and obviously we would not want to go there ;-).

Elia, you brought the MALLOC_CHECK_ up. Did you hear about this issue elsewhere before, and if you did, do you know how other projects solves it?

Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK to your environment before running "make test" suffice?

Elia Pinto· Oct 7, 2012, 13:13 UTC · re: Junio C Hamano · lore

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

Hi Julio.

No, i don't know this message before. Difficult that can be related to a recent glibc change, i think. Perhaps eglibc ? I tomorrow take a look, i am on travel now. Best

2012/10/6, Junio C Hamano <gitster@pobox.com>:
Show 26 quoted lines
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>
>> The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
>> variable, either from the environment or command line of an
>> 'make test' invocation. In order to allow the malloc checks to be
>> disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
>> to the environment using an export directive.
>
> We would want to encourage people to test with cheap but effective
> checks when available.  I do not see "malloc: using debugging hooks"
> message anywhere when I run tests, but if you do, I'd rather see us
> check if we can tell glibc to stop doing so first without disabling
> the whole test.  Your patch feels like the first step to a slipperly
> slope whose destination would make us say "we get too many messages
> so let's do nothing in "make test" with this configuration." when
> taken to the extreme, and obviously we would not want to go there
> ;-).
>
> Elia, you brought the MALLOC_CHECK_ up.  Did you hear about this
> issue elsewhere before, and if you did, do you know how other
> projects solves it?
>
> Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK
> to your environment before running "make test" suffice?
>
>
-- 
Inviato dal mio dispositivo mobile
Elia Pinto· Oct 8, 2012, 13:19 UTC · re: Junio C Hamano · lore

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

2012/10/6 Junio C Hamano <gitster@pobox.com>:
Show 21 quoted lines
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>
>> The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
>> variable, either from the environment or command line of an
>> 'make test' invocation. In order to allow the malloc checks to be
>> disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
>> to the environment using an export directive.
>
> We would want to encourage people to test with cheap but effective
> checks when available.  I do not see "malloc: using debugging hooks"
> message anywhere when I run tests, but if you do, I'd rather see us
> check if we can tell glibc to stop doing so first without disabling
> the whole test.  Your patch feels like the first step to a slipperly
> slope whose destination would make us say "we get too many messages
> so let's do nothing in "make test" with this configuration." when
> taken to the extreme, and obviously we would not want to go there
> ;-).
>
> Elia, you brought the MALLOC_CHECK_ up.  Did you hear about this
> issue elsewhere before, and if you did, do you know how other
> projects solves it?

Ok. I have found. For me this is not a problem any more these days. Was fixed in glibc 2.8.90-9 2008

* Wed Jul 16 2008 Jakub Jelinek <jakub@redhat.com> 2.8.90-9
- update from trunk
  - fix unbuffered vfprintf if writing to the stream fails (#455360)
  - remove useless "malloc: using debugging hooks" message (#455355)
  - nscd fixes
(from glibc rpm changelog)

This is the bugzilla filled and closed https://bugzilla.redhat.com/show_bug.cgi?id=455355

Ramsay, what version of glibc you have and in what distro? thanks
Christian Couder· Oct 9, 2012, 12:33 UTC · re: Elia Pinto · lore

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

Hi,
On Mon, Oct 8, 2012 at 3:19 PM, Elia Pinto <gitter.spiros@gmail.com> wrote:
Show 14 quoted lines
> Ok. I have found. For me this is not a problem any more these days.
> Was fixed in glibc 2.8.90-9 2008
>
> * Wed Jul 16 2008 Jakub Jelinek <jakub@redhat.com> 2.8.90-9
> - update from trunk
>   - fix unbuffered vfprintf if writing to the stream fails (#455360)
>   - remove useless "malloc: using debugging hooks" message (#455355)
>   - nscd fixes
> (from glibc rpm changelog)
>
> This is the bugzilla filled and closed
> https://bugzilla.redhat.com/show_bug.cgi?id=455355
>
> Ramsay, what version of glibc you have and in what distro? thanks

I have the same problem on a RHEL 5.3 (2.6.18-128.el5 #1 SMP Wed Dec 17 11:41:38 EST 2008 x86_64 x86_64 x86_64 GNU/Linux) with glibc-2.5-34.

Best, Christian.

Ramsay Jones· Oct 10, 2012, 17:55 UTC · re: Elia Pinto · lore

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

Elia Pinto wrote:
Show 19 quoted lines
> 2012/10/6 Junio C Hamano <gitster@pobox.com>:
>> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>> Elia, you brought the MALLOC_CHECK_ up.  Did you hear about this
>> issue elsewhere before, and if you did, do you know how other
>> projects solves it?
> Ok. I have found. For me this is not a problem any more these days.
> Was fixed in glibc 2.8.90-9 2008
> 
> * Wed Jul 16 2008 Jakub Jelinek <jakub@redhat.com> 2.8.90-9
> - update from trunk
>   - fix unbuffered vfprintf if writing to the stream fails (#455360)
>   - remove useless "malloc: using debugging hooks" message (#455355)
>   - nscd fixes
> (from glibc rpm changelog)
> 
> This is the bugzilla filled and closed
> https://bugzilla.redhat.com/show_bug.cgi?id=455355
> 
> Ramsay, what version of glibc you have and in what distro? thanks
The glibc version is 2.5, if I believe the changelog, along with:
    ramsay$ ls -l /lib/libc.so.6
    lrwxrwxrwx 1 root root 11 2007-06-24 19:44 /lib/libc.so.6 -> libc-2.5.so*
    ramsay$ 
... but the header files tell a different story:
    ramsay$ grep 'define     __GLIBC_' /usr/include/features.h
    #define __GLIBC__       2
    #define __GLIBC_MINOR__ 4
    ramsay$

The distro is Ubuntu (but I can't remember which version; I would have to re-boot to find out so ...).

HTH

ATB, Ramsay Jones

Ramsay Jones· Oct 10, 2012, 17:46 UTC · re: Junio C Hamano · lore

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

Junio C Hamano wrote:
Show 17 quoted lines
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> 
>> The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
>> variable, either from the environment or command line of an
>> 'make test' invocation. In order to allow the malloc checks to be
>> disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
>> to the environment using an export directive.
> 
> We would want to encourage people to test with cheap but effective
> checks when available.  I do not see "malloc: using debugging hooks"
> message anywhere when I run tests, but if you do, I'd rather see us
> check if we can tell glibc to stop doing so first without disabling
> the whole test.  Your patch feels like the first step to a slipperly
> slope whose destination would make us say "we get too many messages
> so let's do nothing in "make test" with this configuration." when
> taken to the extreme, and obviously we would not want to go there
> ;-).
[sorry for the late reply, I've been away ...]

Yes, but ... I really don't see that this patch would encourage anyone to skip the malloc checks, who wasn't going to anyway! I didn't notice much of an increase in the running time of the tests, so that wouldn't discourage me. This idiotic message spewage is a different issue. (the complete loss of terminal scroll-back is particularly annoying)

I had intended to run the tests with malloc checks enabled before submitting patches, testing -rc* builds etc., but have them disabled for day-to-day programming.

> Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK
> to your environment before running "make test" suffice?

Yes, so I can simply disable the malloc checks in my ~/.bashrc file. However, it would be disappointing to have my config tweeks in two places ... :(

I guess I can live with it ...

ATB, Ramsay Jones

Elia Pinto· Oct 10, 2012, 18:35 UTC · re: Ramsay Jones · lore

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

Hemm, too old release distro , no ? 4-5 year ago. It is time to upgrade to something more recent , 5.7 5.8 . Rhel5.3 is not a good distro for a developer isn't it ?

2012/10/10, Ramsay Jones <ramsay@ramsay1.demon.co.uk>:
Show 46 quoted lines
> Junio C Hamano wrote:
>> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>>
>>> The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
>>> variable, either from the environment or command line of an
>>> 'make test' invocation. In order to allow the malloc checks to be
>>> disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
>>> to the environment using an export directive.
>>
>> We would want to encourage people to test with cheap but effective
>> checks when available.  I do not see "malloc: using debugging hooks"
>> message anywhere when I run tests, but if you do, I'd rather see us
>> check if we can tell glibc to stop doing so first without disabling
>> the whole test.  Your patch feels like the first step to a slipperly
>> slope whose destination would make us say "we get too many messages
>> so let's do nothing in "make test" with this configuration." when
>> taken to the extreme, and obviously we would not want to go there
>> ;-).
>
> [sorry for the late reply, I've been away ...]
>
> Yes, but ... I really don't see that this patch would encourage anyone
> to skip the malloc checks, who wasn't going to anyway! I didn't notice
> much of an increase in the running time of the tests, so that wouldn't
> discourage me. This idiotic message spewage is a different issue.
> (the complete loss of terminal scroll-back is particularly annoying)
>
> I had intended to run the tests with malloc checks enabled before
> submitting patches, testing -rc* builds etc., but have them disabled
> for day-to-day programming.
>
>> Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK
>> to your environment before running "make test" suffice?
>
> Yes, so I can simply disable the malloc checks in my ~/.bashrc file.
> However, it would be disappointing to have my config tweeks in two
> places ... :(
>
> I guess I can live with it ...
>
> ATB,
> Ramsay Jones
>
>
>
>
-- 
Inviato dal mio dispositivo mobile
Elia Pinto· Oct 10, 2012, 18:38 UTC · re: Elia Pinto · lore

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

No reboot.  lsb-release -a from memory or something similar, always on travel...
Regards
2012/10/10, Elia Pinto <gitter.spiros@gmail.com>:
Show 55 quoted lines
> Hemm, too old release distro , no ? 4-5 year ago. It is time to
> upgrade to something more recent , 5.7 5.8 . Rhel5.3 is not a good
> distro for a developer isn't it ?
>
> 2012/10/10, Ramsay Jones <ramsay@ramsay1.demon.co.uk>:
>> Junio C Hamano wrote:
>>> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>>>
>>>> The malloc checks can be disabled using the TEST_NO_MALLOC_CHECK
>>>> variable, either from the environment or command line of an
>>>> 'make test' invocation. In order to allow the malloc checks to be
>>>> disabled from the 'config.mak' file, we add TEST_NO_MALLOC_CHECK
>>>> to the environment using an export directive.
>>>
>>> We would want to encourage people to test with cheap but effective
>>> checks when available.  I do not see "malloc: using debugging hooks"
>>> message anywhere when I run tests, but if you do, I'd rather see us
>>> check if we can tell glibc to stop doing so first without disabling
>>> the whole test.  Your patch feels like the first step to a slipperly
>>> slope whose destination would make us say "we get too many messages
>>> so let's do nothing in "make test" with this configuration." when
>>> taken to the extreme, and obviously we would not want to go there
>>> ;-).
>>
>> [sorry for the late reply, I've been away ...]
>>
>> Yes, but ... I really don't see that this patch would encourage anyone
>> to skip the malloc checks, who wasn't going to anyway! I didn't notice
>> much of an increase in the running time of the tests, so that wouldn't
>> discourage me. This idiotic message spewage is a different issue.
>> (the complete loss of terminal scroll-back is particularly annoying)
>>
>> I had intended to run the tests with malloc checks enabled before
>> submitting patches, testing -rc* builds etc., but have them disabled
>> for day-to-day programming.
>>
>>> Besides, doesn't a simple instruction to export TEST_NO_MALLOC_CHECK
>>> to your environment before running "make test" suffice?
>>
>> Yes, so I can simply disable the malloc checks in my ~/.bashrc file.
>> However, it would be disappointing to have my config tweeks in two
>> places ... :(
>>
>> I guess I can live with it ...
>>
>> ATB,
>> Ramsay Jones
>>
>>
>>
>>
>
> --
> Inviato dal mio dispositivo mobile
>
-- 
Inviato dal mio dispositivo mobile
Junio C Hamano· Oct 10, 2012, 19:16 UTC · re: Ramsay Jones · lore

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
Show 5 quoted lines
> Yes, so I can simply disable the malloc checks in my ~/.bashrc file.
> However, it would be disappointing to have my config tweeks in two
> places ... :(
>
> I guess I can live with it ...

You could write "export that-variable" in your config.mak yourself ;-) Let's apply the patch as-is.

Ramsay Jones· Oct 11, 2012, 20:17 UTC · re: Junio C Hamano · lore

Re: [PATCH] MALLOC_CHECK: Allow checking to be disabled from config.mak

Junio C Hamano wrote:
Show 10 quoted lines
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> 
>> Yes, so I can simply disable the malloc checks in my ~/.bashrc file.
>> However, it would be disappointing to have my config tweeks in two
>> places ... :(
>>
>> I guess I can live with it ...
> 
> You could write "export that-variable" in your config.mak yourself
> ;-)  Let's apply the patch as-is.
*smacks forehead* ;-P ... now why didn't I think of that! *blush* [1]
Thanks!

ATB, Ramsay Jones

[1] I am more than a little disappointed in myself, because I have done exactly this, *several* times, on other (much older) projects.

← back to recent threads