git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: A possible fmt-merge-msg update?

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Mar 5, 2012, 05:24 UTC
Message-ID
<CA+55aFzQ3+EFBVyE9PWOyH0XEC_oW+kUaBTYfixmi2wgMmiZvw@mail.gmail.com>
In-Reply-To
<7vvcmj68iz.fsf@alter.siamese.dyndns.org>
On Sun, Mar 4, 2012 at 7:17 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
>
> Having observed a handful of your recent merge messages, I am wondering if
> it would help to teach fmt-merge-msg to include "from Wim Van Sebroeck" in
> its output by taking the committer of the MERGE_HEAD into account.
>
> Not worth the trouble?
Hmm. Maybe worth it.

So the reason I've started to try to do it is that I had a person email me about appreciating the new merge messages, but he also said he wanted to know who I pulled from. And I agree that that makes sense as a real piece of information.

It's not *necessarily* the same person as the committer info, though. It probably matches a very high percentage of the time, but the pull request doesn't always come from the person doing the commits. The x86 people have this "tip" thing, and while branches tend to be owned by the people doing the pull request, it's not a given. And sometimes you have a submaintainer who pulled from *his* submaintainer, and didn't have any work of his own, so he asks me to pull something where the top is not him, but his submaintainer.

So I really dunno.

It might be interesting if the pre-written commit message had the top committer in a comment (the same way pulling a tag has the tag author in the comment about the tag verification). That way the information would be right there when I edit the message, and since it's correct 99% of the time it would make it easier to just edit it in the editor than have to cut-and-paste it from the email. But because it's not a sure thing, it would be a comment-only thing where I can choose to remove the '# ' in front of it. Maybe that would be the best of both worlds - helping write a merge message without assuming it has to be that way..

                       Linus
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 36 in “A possible fmt-merge-msg update?”
  1. Junio C HamanoMar 5, 2012
  2. Linus TorvaldsMar 5, 2012
  3. Junio C HamanoMar 5, 2012
  4. Linus TorvaldsMar 5, 2012
  5. fmt-merge-msg: show those involved in a merged seriesJunio C Hamano, Mar 5, 2012
  6. Linus TorvaldsMar 5, 2012
  7. Junio C HamanoMar 5, 2012
  8. René ScharfeMar 7, 2012
  9. Junio C HamanoMar 7, 2012
  10. René ScharfeMar 8, 2012
  11. Junio C HamanoMar 8, 2012
  12. Junio C HamanoMar 8, 2012
  13. Phil HordMar 12, 2012
  14. Jeff KingMar 13, 2012
  15. Junio C HamanoMar 14, 2012
  16. Phil HordMar 14, 2012
  17. Jonathan NiederMar 12, 2012
  18. Junio C HamanoMar 13, 2012
  19. Jonathan NiederMar 13, 2012
  20. Junio C HamanoMar 13, 2012
  21. Johannes SixtMar 13, 2012
  22. Junio C HamanoMar 13, 2012
  23. Johannes SixtMar 14, 2012
  24. Junio C HamanoMar 14, 2012
  25. 1/1 fmt-merge-msg: show those involved in a merged seriesJunio C Hamano, Mar 13, 2012
  26. fmt-merge-msg: add a blank line after people infoJonathan Nieder, May 11, 2012
  27. Junio C HamanoMay 11, 2012
  28. Linus TorvaldsMay 11, 2012
  29. Junio C HamanoMay 14, 2012
  30. Junio C HamanoMay 15, 2012
  31. Linus TorvaldsMay 16, 2012
  32. Junio C HamanoMay 16, 2012
  33. Jonathan NiederJun 6, 2012
  34. Jonathan NiederJun 6, 2012
  35. Junio C HamanoJun 6, 2012
  36. Jeff KingMar 6, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.