Re: [PATCH] fmt-merge-msg: show those involved in a merged series

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 12, 2012, 07:11 UTC
Message-ID: <20120312071121.GA17269@burratino>
In-Reply-To: <7vmx7uzq8h.fsf_-_@alter.siamese.dyndns.org>

Hi,

Junio C Hamano wrote:

Show 10 quoted lines

> * jc/fmt-merge-msg-people (2012-03-08) 3 commits
>   (merged to 'next' on 2012-03-08 at be31aa9)
>  + fmt-merge-msg.c: make util_as_int() return "int"
>   (merged to 'next' on 2012-03-07 at 76fbac3)
>  + fmt-merge-msg: finishing touches
>   (merged to 'next' on 2012-03-05 at 38de349)
>  + fmt-merge-msg: show those involved in a merged series
>
> The "fmt-merge-msg" command learns to list the primary contributors
> involved in the side topic you are merging.

Ah, so that's where the funny

	By Jonathan Nieder
	via Jonathan Nieder

lines in

	Merge branch 'jn/maint-fast-import-empty-ls' into pu

	By Jonathan Nieder
	via Jonathan Nieder
	* jn/maint-fast-import-empty-ls:
	  fast-import: don't allow 'ls' of path with empty components
	  fast-import: leakfix for 'ls' of dirty trees

come from. As a person reading the history, I admit I don't like it. I enjoyed being able to get a simple overview at a higher level of what has been happening in "pu" with "git log --merges junio/pu" or "git log --first-parent junio/pu", and these extra lines before and adjacent to the "* name of topic:" header interfere with that.

By contrast, the

	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs

	Pull btrfs updates from Chris Mason:
	[more words about that here]

	* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs:
	 Btrfs: fix casting error in scrub reada code
	[...]

descriptions in Linus's repo are very pleasant. It's a subtle difference, but the extra whitespace and the way it presents the important bits like "Pull btrfs updates" before the mechanics "from Chris Mason" help.

So I like the goal, but something about this execution does not seem to be working. Sorry I have no better news or more concrete feedback to offer.

Jonathan