Re: [PATCH] fmt-merge-msg: show those involved in a merged series
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 8, 2012, 19:18 UTC
- Message-ID
- <7v1up2ew9u.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4F58F06A.1070108@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
Show 16 quoted lines
> Am 07.03.2012 22:59, schrieb Junio C Hamano: >> René Scharfe<rene.scharfe@lsrfire.ath.cx> writes: >> >>> Am 05.03.2012 22:34, schrieb Junio C Hamano: >>> >>>> +#define util_as_int(elem) ((intptr_t)((elem)->util)) >>> >>> Something that actually returns an int would fit the name better. ;) >> >> The particular type would not matter to the callers of the helper >> macro, would it? > > Three of the five callers introduced in that commit cast the result to > int and the remaining two don't care, so it actually does seem to > matter for most of them, strictly speaking. When I see a nit, I can't > resist the urge to pick it, apparently.
Unfortunately, replacing intptr_t with int or casting the above again as int will result in
builtin/fmt-merge-msg.c: In function 'record_person': builtin/fmt-merge-msg.c:213: error: cast to pointer from integer of different size
So...