Re: [PATCH v4 1/3] t: do not hide Git's exit code in tests
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Feb 16, 2016, 09:36 UTC
- Message-ID
- <C99C00B1-B782-4CCD-A1B5-B83CE50DE6C8@gmail.com>
- In-Reply-To
- <20160215174157.GA26443@sigill.intra.peff.net>
On 15 Feb 2016, at 18:41, Jeff King <peff@peff.net> wrote:
Show 13 quoted lines
> On Mon, Feb 15, 2016 at 11:17:44AM +0100, larsxschneider@gmail.com wrote: > >> From: Lars Schneider <larsxschneider@gmail.com> >> >> Git should not be on the left-hand side of a pipe, because it hides the exit >> code, and we want to make sure git does not fail. > > I think this is a nice cleanup. > >> There is one more occurrence of this pattern in t9010-svn-fe.sh which is to >> evolved to change it easily. > > The final sentence in the commit message needs s/to/too/.
OK!
Show 8 quoted lines
> However, I'm > not sure this is the only remaining case. Doing: > > git grep -E 'git.*[^|]\|($|[^|])' > > shows quite a few. I guess you just looked for "nul_to_q". There is > certainly no need to fix all of them, but you may want to note the > extent of your grepping in your commit message.
Yes, I looked only for nul_to_q... there are more than 1000 other cases. I thought about a clever sed script to fix the easy ones but I don't think it is worth the effort.
Thanks, Lars