git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 1/3] t: do not hide Git's exit code in tests

From
Lars Schneider <larsxschneider@gmail.com>
Date
Feb 16, 2016, 09:36 UTC
Message-ID
<C99C00B1-B782-4CCD-A1B5-B83CE50DE6C8@gmail.com>
In-Reply-To
<20160215174157.GA26443@sigill.intra.peff.net>
On 15 Feb 2016, at 18:41, Jeff King <peff@peff.net> wrote:
Show 13 quoted lines
> On Mon, Feb 15, 2016 at 11:17:44AM +0100, larsxschneider@gmail.com wrote:
> 
>> From: Lars Schneider <larsxschneider@gmail.com>
>> 
>> Git should not be on the left-hand side of a pipe, because it hides the exit
>> code, and we want to make sure git does not fail.
> 
> I think this is a nice cleanup.
> 
>> There is one more occurrence of this pattern in t9010-svn-fe.sh which is to
>> evolved to change it easily.
> 
> The final sentence in the commit message needs s/to/too/.
OK!
Show 8 quoted lines
> However, I'm
> not sure this is the only remaining case. Doing:
> 
>  git grep -E 'git.*[^|]\|($|[^|])'
> 
> shows quite a few. I guess you just looked for "nul_to_q". There is
> certainly no need to fix all of them, but you may want to note the
> extent of your grepping in your commit message.

Yes, I looked only for nul_to_q... there are more than 1000 other cases. I thought about a clever sed script to fix the easy ones but I don't think it is worth the effort.

Thanks, Lars

Previous: Jeff KingNext: larsxschneider@gmail.com
Message 4 of 32 in “config: add '--sources' option to print the source of a config value”
  1. 0/3 config: add '--sources' option to print the source of a config valuelarsxschneider@gmail.com, Feb 15, 2016
  2. 1/3 t: do not hide Git's exit code in testslarsxschneider@gmail.com, Feb 15, 2016
  3. Jeff KingFeb 15, 2016
  4. Lars SchneiderFeb 16, 2016
  5. 2/3 config: add 'type' to config_source struct that identifies config typelarsxschneider@gmail.com, Feb 15, 2016
  6. Jeff KingFeb 15, 2016
  7. Ramsay JonesFeb 16, 2016
  8. Ramsay JonesFeb 15, 2016
  9. Johannes SchindelinFeb 17, 2016
  10. Lars SchneiderFeb 18, 2016
  11. 3/3 config: add '--show-origin' option to print the origin of a config valuelarsxschneider@gmail.com, Feb 15, 2016
  12. Jeff KingFeb 15, 2016
  13. Eric SunshineFeb 15, 2016
  14. Jeff KingFeb 15, 2016
  15. Lars SchneiderFeb 17, 2016
  16. Junio C HamanoFeb 17, 2016
  17. Ramsay JonesFeb 15, 2016
  18. Jeff KingFeb 15, 2016
  19. Ramsay JonesFeb 15, 2016
  20. Lars SchneiderFeb 16, 2016
  21. Ramsay JonesFeb 16, 2016
  22. Jeff KingFeb 16, 2016
  23. Ramsay JonesFeb 16, 2016
  24. Jeff KingFeb 16, 2016
  25. Junio C HamanoFeb 15, 2016
  26. Lars SchneiderFeb 16, 2016
  27. Junio C HamanoFeb 15, 2016
  28. Jeff KingFeb 15, 2016
  29. Junio C HamanoFeb 15, 2016
  30. Lars SchneiderFeb 16, 2016
  31. Jeff KingFeb 15, 2016
  32. Lars SchneiderFeb 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.