Re: [PATCH v4 3/3] config: add '--show-origin' option to print the origin of a config value
- From
Jeff King <peff@peff.net>
- Date
- Feb 15, 2016, 18:06 UTC
- Message-ID
- <20160215180644.GD26443@sigill.intra.peff.net>
- In-Reply-To
- <1455531466-16617-4-git-send-email-larsxschneider@gmail.com>
On Mon, Feb 15, 2016 at 11:17:46AM +0100, larsxschneider@gmail.com wrote:
Show 16 quoted lines
> From: Lars Schneider <larsxschneider@gmail.com> > > If config values are queried using 'git config' (e.g. via --get, > --get-all, --get-regexp, or --list flag) then it is sometimes hard to > find the configuration file where the values were defined. > > Teach 'git config' the '--show-origin' option to print the source > configuration file for every printed value. > > Based-on-patch-by: Jeff King <peff@peff.net> > Signed-off-by: Lars Schneider <larsxschneider@gmail.com> > --- > Documentation/git-config.txt | 15 +++-- > builtin/config.c | 33 ++++++++++ > t/t1300-repo-config.sh | 153 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 196 insertions(+), 5 deletions(-)
I packed all of my thoughts on test tear-down into my response to the cover letter. :)
Other than that minor point, this version looks good to me.
-Peff