Re: [PATCH v4 1/3] t: do not hide Git's exit code in tests

From: Jeff King <peff@peff.net>
Date: Feb 15, 2016, 17:41 UTC
Message-ID: <20160215174157.GA26443@sigill.intra.peff.net>
In-Reply-To: <1455531466-16617-2-git-send-email-larsxschneider@gmail.com>

On Mon, Feb 15, 2016 at 11:17:44AM +0100, larsxschneider@gmail.com wrote:

> From: Lars Schneider <larsxschneider@gmail.com>
> 
> Git should not be on the left-hand side of a pipe, because it hides the exit
> code, and we want to make sure git does not fail.

I think this is a nice cleanup.

> There is one more occurrence of this pattern in t9010-svn-fe.sh which is to
> evolved to change it easily.

The final sentence in the commit message needs s/to/too/. However, I'm not sure this is the only remaining case. Doing:

  git grep -E 'git.*[^|]\|($|[^|])'

shows quite a few. I guess you just looked for "nul_to_q". There is certainly no need to fix all of them, but you may want to note the extent of your grepping in your commit message.

-Peff