git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 6/6] convert: add "status=delayed" to filter process protocol

From
Lars Schneider <larsxschneider@gmail.com>
Date
Jun 29, 2017, 18:46 UTC
Message-ID
<C36BBCCA-6694-40EC-8E1A-36B0CB9D4B2D@gmail.com>
In-Reply-To
<xmqqinjetzgc.fsf@gitster.mtv.corp.google.com>
Show 8 quoted lines
> On 29 Jun 2017, at 20:34, Junio C Hamano <gitster@pobox.com> wrote:
> 
> You seem to have squashed an unrelated "table-driven" clean-up into
> this step.  While I think the end result looks good, I would have
> liked to see it as a separate step, either as a preparatory "now we
> are going to add the third one, let's make it table-driven before
> doing so" step, or a follow-up "now we have done everything we
> wanted to do, let's make this clean-up at the end" step.

I am sorry. That was a misunderstanding - I thought you want to have this change squashed.

The "preparatory" patch sounds good! Would you be OK if I send a v9 with this change?

Thanks, Lars

Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 11 in “convert: add "status=delayed" to filter process protocol”
  1. 0/6 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 28, 2017
  2. 1/6 t0021: keep filter log files on comparisonLars Schneider, Jun 28, 2017
  3. 3/6 t0021: write "OUT <size>" only on successLars Schneider, Jun 28, 2017
  4. 2/6 t0021: make debug log file name configurableLars Schneider, Jun 28, 2017
  5. 4/6 convert: put the flags field before the flag itself for consistent styleLars Schneider, Jun 28, 2017
  6. 5/6 convert: move multiple file filter error handling to separate functionLars Schneider, Jun 28, 2017
  7. 6/6 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 28, 2017
  8. Junio C HamanoJun 29, 2017
  9. Lars SchneiderJun 29, 2017
  10. Junio C HamanoJun 30, 2017
  11. Lars SchneiderJun 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.