Re: [PATCH v8 6/6] convert: add "status=delayed" to filter process protocol
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Jun 30, 2017, 20:44 UTC
- Message-ID
- <5D20EDDE-C3A9-454E-8678-2703676CC99C@gmail.com>
- In-Reply-To
- <xmqq4luxs5hu.fsf@gitster.mtv.corp.google.com>
Show 21 quoted lines
> On 30 Jun 2017, at 20:19, Junio C Hamano <gitster@pobox.com> wrote: > > Lars Schneider <larsxschneider@gmail.com> writes: > >>> On 29 Jun 2017, at 20:34, Junio C Hamano <gitster@pobox.com> wrote: >>> >>> You seem to have squashed an unrelated "table-driven" clean-up into >>> this step. While I think the end result looks good, I would have >>> liked to see it as a separate step, either as a preparatory "now we >>> are going to add the third one, let's make it table-driven before >>> doing so" step, or a follow-up "now we have done everything we >>> wanted to do, let's make this clean-up at the end" step. >> >> I am sorry. That was a misunderstanding - I thought you want to have >> this change squashed. >> >> The "preparatory" patch sounds good! >> Would you be OK if I send a v9 with this change? > > That would be more than OK. I think we are pretty much ready to hit > 'next'.
Done: http://public-inbox.org/git/20170630204128.48708-1-larsxschneider@gmail.com/
My brain is fried already today ... I hope the commit message is OK :)
Thanks, Lars