git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 1/6] t0021: keep filter log files on comparison

From
Lars Schneider <larsxschneider@gmail.com>
Date
Jun 28, 2017, 21:29 UTC
Message-ID
<20170628212952.60781-2-larsxschneider@gmail.com>
In-Reply-To
<20170628212952.60781-1-larsxschneider@gmail.com>

The filter log files are modified on comparison. That might be unexpected by the caller. It would be even undesirable if the caller wants to reuse the original log files.

Address these issues by using temp files for modifications. This is useful for the subsequent patch 'convert: add "status=delayed" to filter process protocol'.

Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
 t/t0021-conversion.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh
index 161f560446..ff2424225b 100755
--- a/t/t0021-conversion.sh
+++ b/t/t0021-conversion.sh
@@ -42,10 +42,10 @@ test_cmp_count () {
 	for FILE in "$expect" "$actual"
 	do
 		sort "$FILE" | uniq -c |
-		sed -e "s/^ *[0-9][0-9]*[ 	]*IN: /x IN: /" >"$FILE.tmp" &&
-		mv "$FILE.tmp" "$FILE" || return
+		sed -e "s/^ *[0-9][0-9]*[ 	]*IN: /x IN: /" >"$FILE.tmp"
 	done &&
-	test_cmp "$expect" "$actual"
+	test_cmp "$expect.tmp" "$actual.tmp" &&
+	rm "$expect.tmp" "$actual.tmp"
 }
 
 # Compare two files but exclude all `clean` invocations because Git can
@@ -56,10 +56,10 @@ test_cmp_exclude_clean () {
 	actual=$2
 	for FILE in "$expect" "$actual"
 	do
-		grep -v "IN: clean" "$FILE" >"$FILE.tmp" &&
-		mv "$FILE.tmp" "$FILE"
+		grep -v "IN: clean" "$FILE" >"$FILE.tmp"
 	done &&
-	test_cmp "$expect" "$actual"
+	test_cmp "$expect.tmp" "$actual.tmp" &&
+	rm "$expect.tmp" "$actual.tmp"
 }
 
 # Check that the contents of two files are equal and that their rot13 version
-- 
2.13.2
Previous: Lars SchneiderNext: Lars Schneider
Message 2 of 11 in “convert: add "status=delayed" to filter process protocol”
  1. 0/6 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 28, 2017
  2. 1/6 t0021: keep filter log files on comparisonLars Schneider, Jun 28, 2017
  3. 3/6 t0021: write "OUT <size>" only on successLars Schneider, Jun 28, 2017
  4. 2/6 t0021: make debug log file name configurableLars Schneider, Jun 28, 2017
  5. 4/6 convert: put the flags field before the flag itself for consistent styleLars Schneider, Jun 28, 2017
  6. 5/6 convert: move multiple file filter error handling to separate functionLars Schneider, Jun 28, 2017
  7. 6/6 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 28, 2017
  8. Junio C HamanoJun 29, 2017
  9. Lars SchneiderJun 29, 2017
  10. Junio C HamanoJun 30, 2017
  11. Lars SchneiderJun 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.