git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Whitespace and '&nbsp'

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
May 27, 2011, 21:14 UTC
Message-ID
<BANLkTinwOr5Yzp_N6BNyNK5Y1FcVtdtbUw@mail.gmail.com>
In-Reply-To
<7vboyorm4i.fsf@alter.siamese.dyndns.org>
On Fri, May 27, 2011 at 12:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> The "diff" side would look like this.  I am tempted to change all the
> "char *line" to "unsigned char *line", before updating "apply", though...
Without actually testing it, it looks reasonable.

I do wonder whether the highlighting might be something that is independent of whitespace issues. What about mis-formed or non-printable characters? Right now we depend on "less" doing the right thing, but I can make "git diff" generate random escape sequences etc by just putting them in the file, so if I do GIT_PAGER=cat I can make "git diff" really mess up my terminal if I wanted to.

Again, I'm not convinced git should really care, but I'm also not convinced that sbsp is necessarily all about the git whitespace fixups.

                     Linus
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 15 in “Whitespace and '&nbsp'”
  1. Linus TorvaldsMay 26, 2011
  2. Junio C HamanoMay 26, 2011
  3. Linus TorvaldsMay 26, 2011
  4. Andreas SchwabMay 27, 2011
  5. Linus TorvaldsMay 27, 2011
  6. Junio C HamanoMay 27, 2011
  7. Junio C HamanoMay 27, 2011
  8. Linus TorvaldsMay 27, 2011
  9. Junio C HamanoMay 27, 2011
  10. 1/3 ws.c: add a helper to format comma separated messagesJunio C Hamano, May 27, 2011
  11. 2/3 War on nbsp: a bit of retreatJunio C Hamano, May 27, 2011
  12. 3/3 War on nbsp: Add "nbsp" whitespace breakage classJunio C Hamano, May 27, 2011
  13. 4/3 War on nbsp: teach "git apply" to check and fix nbspJunio C Hamano, May 28, 2011
  14. Daniel NyströmMay 30, 2011
  15. Matthieu MoyMay 26, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.