git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Whitespace and '&nbsp'

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
May 27, 2011, 17:01 UTC
Message-ID
<BANLkTimPfN6LQBhWj6rW3Zcm9JHPsMWsjA@mail.gmail.com>
In-Reply-To
<m262owhyuy.fsf@igel.home>
On Fri, May 27, 2011 at 9:50 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> Is this a gmail thing?

Gmail on the sending side - quite possibly part of a reflowing thing, especially with quoting. I send patches as attachments because gmail is crap in this regard (and yes, I hate it, and I go back to alpine for any bigger issues).

But on the receiving side? Sounds unlikely, since I've used gmail for the last year to receive patches, and this is the first time I've seen it.

And the sent email that had the issue this time implied mutt, not gmail.

Regardless, what took me by surprise was how (a) the patch applied fine, (b) it _looked_ fine in all the normal tools, and (c) it just didn't work.

Now, very arguably this is not a git issue at all. Having the odd nbsp be more visible in my other tools would have been fine - either 'less' showing it (the way it shows other control characters) or my terminal making some visual distinction. That said, I think it's something that git could perhaps protect against a bit.

                    Linus
Previous: Andreas SchwabNext: Junio C Hamano
Message 5 of 15 in “Whitespace and '&nbsp'”
  1. Linus TorvaldsMay 26, 2011
  2. Junio C HamanoMay 26, 2011
  3. Linus TorvaldsMay 26, 2011
  4. Andreas SchwabMay 27, 2011
  5. Linus TorvaldsMay 27, 2011
  6. Junio C HamanoMay 27, 2011
  7. Junio C HamanoMay 27, 2011
  8. Linus TorvaldsMay 27, 2011
  9. Junio C HamanoMay 27, 2011
  10. 1/3 ws.c: add a helper to format comma separated messagesJunio C Hamano, May 27, 2011
  11. 2/3 War on nbsp: a bit of retreatJunio C Hamano, May 27, 2011
  12. 3/3 War on nbsp: Add "nbsp" whitespace breakage classJunio C Hamano, May 27, 2011
  13. 4/3 War on nbsp: teach "git apply" to check and fix nbspJunio C Hamano, May 28, 2011
  14. Daniel NyströmMay 30, 2011
  15. Matthieu MoyMay 26, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.