From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Fri, 27 May 2011 21:14:54 GMT
Subject: Re: Whitespace and '&nbsp'
Message-ID: <BANLkTinwOr5Yzp_N6BNyNK5Y1FcVtdtbUw@mail.gmail.com>
In-Reply-To: <7vboyorm4i.fsf@alter.siamese.dyndns.org>

On Fri, May 27, 2011 at 12:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> The "diff" side would look like this.  I am tempted to change all the
> "char *line" to "unsigned char *line", before updating "apply", though...

Without actually testing it, it looks reasonable.

I do wonder whether the highlighting might be something that is
independent of whitespace issues. What about mis-formed or
non-printable characters? Right now we depend on "less" doing the
right thing, but I can make "git diff" generate random escape
sequences etc by just putting them in the file, so if I do
GIT_PAGER=cat I can make "git diff" really mess up my terminal if I
wanted to.

Again, I'm not convinced git should really care, but I'm also not
convinced that sbsp is necessarily all about the git whitespace
fixups.

                     Linus