git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] stash: fix false positive in the invalid ref test.

From
Jon Seymour <jon.seymour@gmail.com>
Date
Apr 6, 2011, 22:47 UTC
Message-ID
<BANLkTimqG4XSTRGH-+EMi6vYL7N8JU1Mtw@mail.gmail.com>
In-Reply-To
<20110406182726.GC8205@sigill.intra.peff.net>
On Thu, Apr 7, 2011 at 4:27 AM, Jeff King <peff@github.com> wrote:
> On Wed, Apr 06, 2011 at 09:21:13AM +1000, Jon Seymour wrote:
    git stash drop
>
> Probably we should just squash your fix in with my first patch, and drop
> my test.  Your fixed version is a superset of what mine tests.
>

I was wondering if it might be better to break up the original test, so that each sub-function has its own invalid ref test? If there is agreement, I can do this on top of 9355fc which is the tip of the branch containing these fixes that has been merged into pu.

jon.
Previous: Jeff KingNext: Jeff King
Message 3 of 4 in “stash: fix false positive in the invalid ref test.”
  1. stash: fix false positive in the invalid ref test.Jon Seymour, Apr 5, 2011
  2. Jeff KingApr 6, 2011
  3. Jon SeymourApr 6, 2011
  4. Jeff KingApr 6, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.