From: Jon Seymour Date: Wed, 06 Apr 2011 22:47:07 GMT Subject: Re: [PATCH] stash: fix false positive in the invalid ref test. Message-ID: In-Reply-To: <20110406182726.GC8205@sigill.intra.peff.net> On Thu, Apr 7, 2011 at 4:27 AM, Jeff King wrote: > On Wed, Apr 06, 2011 at 09:21:13AM +1000, Jon Seymour wrote:     git stash drop > > Probably we should just squash your fix in with my first patch, and drop > my test.  Your fixed version is a superset of what mine tests. > I was wondering if it might be better to break up the original test, so that each sub-function has its own invalid ref test? If there is agreement, I can do this on top of 9355fc which is the tip of the branch containing these fixes that has been merged into pu. jon.