Re: [PATCH] stash: fix false positive in the invalid ref test.

From: Jeff King <peff@github.com>
Date: Apr 6, 2011, 18:27 UTC
Message-ID: <20110406182726.GC8205@sigill.intra.peff.net>
In-Reply-To: <1302045673-59982-1-git-send-email-jon.seymour@gmail.com>

On Wed, Apr 06, 2011 at 09:21:13AM +1000, Jon Seymour wrote:

Show 19 quoted lines

> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> index 11077f0..5263de7 100755
> --- a/t/t3903-stash.sh
> +++ b/t/t3903-stash.sh
> @@ -543,11 +543,11 @@ test_expect_success 'invalid ref of the form stash@{n}, n >= N' '
>  	echo bar6 > file2 &&
>  	git add file2 &&
>  	git stash &&
> -	test_must_fail git drop stash@{1} &&
> -	test_must_fail git pop stash@{1} &&
> -	test_must_fail git apply stash@{1} &&
> -	test_must_fail git show stash@{1} &&
> -	test_must_fail git branch tmp stash@{1} &&
> +	test_must_fail git stash drop stash@{1} &&
> +	test_must_fail git stash pop stash@{1} &&
> +	test_must_fail git stash apply stash@{1} &&
> +	test_must_fail git stash show stash@{1} &&
> +	test_must_fail git stash branch tmp stash@{1} &&
>  	git stash drop

Probably we should just squash your fix in with my first patch, and drop my test. Your fixed version is a superset of what mine tests.

-Peff