Re: [PATCH 6/9] gettext.h: Avoid using a non-standard C construct
On Fri, Apr 8, 2011 at 00:10, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 29 quoted lines
> Hi,
>
> Ramsay Jones wrote:
>
>> +++ b/gettext.h
>> @@ -35,6 +35,6 @@ const char *Q_(const char *msgid, const char *plu, unsigned long n)
> [...]
>> -#define N_(msgid) (msgid)
>> +#define N_(msgid) msgid
>
> Good catch. Thanks!
>
>> In particular, standard C does not allow a parenthesized string
>> as an array initializer.
>
> The subject line seems unnecessarily vague. Why not:
>
> i18n: avoid parenthesized string as array initializer
>
> The syntax
>
> static const char ignore_error[] = ("something");
>
> is invalid C. GCC and MSVC can parse it, but for example
> tcc cannot. So remove the parenthesis from the definition
> of the N_() macro.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> Acked-by: Jonathan Nieder <jrnieder@gmail.com>This looks good to me with this commit message:
Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com>