From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sun, 10 Apr 2011 12:54:15 GMT
Subject: Re: [PATCH 6/9] gettext.h: Avoid using a non-standard C construct
Message-ID: <BANLkTimFQjbf6pz7upcb=QJngZdPTgWLmQ@mail.gmail.com>
In-Reply-To: <20110407221015.GA20080@elie>

On Fri, Apr 8, 2011 at 00:10, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Hi,
>
> Ramsay Jones wrote:
>
>> +++ b/gettext.h
>> @@ -35,6 +35,6 @@ const char *Q_(const char *msgid, const char *plu, unsigned long n)
> [...]
>> -#define N_(msgid) (msgid)
>> +#define N_(msgid) msgid
>
> Good catch.  Thanks!
>
>> In particular, standard C does not allow a parenthesized string
>> as an array initializer.
>
> The subject line seems unnecessarily vague.  Why not:
>
>        i18n: avoid parenthesized string as array initializer
>
>        The syntax
>
>                static const char ignore_error[] = ("something");
>
>        is invalid C.  GCC and MSVC can parse it, but for example
>        tcc cannot.  So remove the parenthesis from the definition
>        of the N_() macro.
>
>        Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
>        Acked-by: Jonathan Nieder <jrnieder@gmail.com>

This looks good to me with this commit message:

Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>