Re: [PATCH 6/9] gettext.h: Avoid using a non-standard C construct
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- Apr 11, 2011, 17:15 UTC
- Message-ID
- <4DA33735.5070402@ramsay1.demon.co.uk>
- In-Reply-To
- <20110407221015.GA20080@elie>
Jonathan Nieder wrote:
Show 26 quoted lines
>> +++ b/gettext.h
>> @@ -35,6 +35,6 @@ const char *Q_(const char *msgid, const char *plu, unsigned long n)
> [...]
>> -#define N_(msgid) (msgid)
>> +#define N_(msgid) msgid
>
> Good catch. Thanks!
>
>> In particular, standard C does not allow a parenthesized string
>> as an array initializer.
>
> The subject line seems unnecessarily vague. Why not:
>
> i18n: avoid parenthesized string as array initializer
>
> The syntax
>
> static const char ignore_error[] = ("something");
>
> is invalid C. GCC and MSVC can parse it, but for example
> tcc cannot. So remove the parenthesis from the definition
> of the N_() macro.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> Acked-by: Jonathan Nieder <jrnieder@gmail.com>
> Sounds good to me. I'll re-roll and use your message verbatim.
Thanks!
ATB, Ramsay Jones