git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] convert.c clean-up

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
May 10, 2011, 12:59 UTC
Message-ID
<BANLkTi=fjLkqWB2MTGtKE93qSjXU76cpvA@mail.gmail.com>
In-Reply-To
<1304978701-19310-1-git-send-email-gitster@pobox.com>
On Tue, May 10, 2011 at 5:04 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
> Yeah, I think that would probably make more sense. If a file is small
> enough, it is more sensible to send it to a loose object just like any
> other files. We do not want to invite users to make a mistake of marking
> it as bigdata and send it straight to a packfile. Having one less knob to
> tweak is always a good thing to do.
>
> However, while reviewing your patch, I noticed that convert.c was littered
> with misnamed types, variables and functions to the point to make it
> almost unreadble as the result of its evolution.  I originally wrote this
> series so that I can add "bigdata" sensibly, and it turns out that there
> is no benefit to do so for now, but the clean-up by itself would be worth
> it.

I still don't like "bigdata" attribute. It sounds overlapping with bigFileThreshold we already have. Maybe "inPack", "packed" or "noLoose" a better name? It makes it quite clear that this attribute sends objects to a pack. If they want to process tiny files this way by setting inPack/noLoose, I don't care. But files larger than core.bigFileThreshold should be automatically marked "inPack/noLoose".

> So there...

Yeah, I wish you did this before I touched convert.c. Anyway it looks better from now on.

-- 
Duy
Previous: Junio C HamanoNext: Junio C Hamano
Message 12 of 18 in “git add a-Big-file”
  1. 0/3 git add a-Big-fileJunio C Hamano, May 8, 2011
  2. 1/3 index_fd(): turn write_object and format_check arguments into one flagJunio C Hamano, May 8, 2011
  3. 2/3 index_fd(): split into two helper functionsJunio C Hamano, May 8, 2011
  4. 3/3 Bigfile: teach "git add" to send a large file straight to a packJunio C Hamano, May 8, 2011
  5. Nguyen Thai Ngoc DuyMay 8, 2011
  6. Junio C HamanoMay 8, 2011
  7. 0/4 convert.c clean-upJunio C Hamano, May 9, 2011
  8. 1/4 convert: rename the "eol" global variable to "core_eol"Junio C Hamano, May 9, 2011
  9. 2/4 convert: give saner names to crlf/eol variables, types and functionsJunio C Hamano, May 9, 2011
  10. 3/4 convert: make it safer to add conversion attributesJunio C Hamano, May 9, 2011
  11. 4/4 convert: make it harder to screw up adding a conversion attributeJunio C Hamano, May 9, 2011
  12. Nguyen Thai Ngoc DuyMay 10, 2011
  13. Junio C HamanoMay 10, 2011
  14. Shawn PearceMay 9, 2011
  15. Junio C HamanoMay 9, 2011
  16. Junio C HamanoMay 9, 2011
  17. Ævar Arnfjörð BjarmasonMay 29, 2011
  18. Junio C HamanoMay 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.