git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/8] Documentation: rename docbook-xsl-172 attribute to git-asciidoc-no-roff

From
Chris Johnsen <chris_johnsen@pobox.com>
Date
Mar 24, 2009, 19:48 UTC
Message-ID
<B70DE0F1-8CDA-46FC-9EF8-41B0FAC39631@pobox.com>
In-Reply-To
<20090324090440.GC1799@coredump.intra.peff.net>
On 2009 Mar 24, at 04:04, Jeff King wrote:
Show 27 quoted lines
> On Tue, Mar 24, 2009 at 03:04:21AM -0500, Chris Johnsen wrote:
>
>> It seems that the ability to use raw roff codes in asciidoc.conf
>> was eliminated by docbook-xsl 1.72.0 _and later_. Unlike the
>> 1.72.0-specific XSLT problem, this behavior was not reverted in
>> later releases.
>>
>> This patch aims to make it clear that the affected asciidoc
>> attribute (flag) can be reasonably used with docbook-xsl versions
>> other than 1.72.0.
>
> Great, this looks like a definite improvement. Should we be respecting
> more DOCBOOK_XSL_* variables than just 172, then? I.e.,:
>
>> +# For docbook-xsl ...
>> +#	-1.68.1,	set ASCIIDOC_NO_ROFF? (based on changelog from 1.73.0)
>> +#	1.69.0-1.71.1,	no extra settings are needed?
>> +#	1.72.0,		set DOCBOOK_XSL_172.
>> +#	1.73.0-,	set ASCIIDOC_NO_ROFF
>
> DOCBOOK_XSL_173, etc?
>
> I don't know that we need to cover _every_ version, but if we can have
> specific knobs for individual features (like ASCIIDOC_NO_ROFF), then
> maybe it makes sense to aggregate the settings for those knobs for  
> a few
> common versions.

I am not opposed to providing more version-specific controls, but I am not sure which versions are important enough to justify their own variables. Are you indicating that 1.73 is important enough because it was a "return to sanity" after 1.72?

The versions I listed in the comments were just the ones that the tools' documentation described as needing one adjustment or another. I thought the comments would be an easy way to start tracking which versions were "interesting".

-- 
Chris
Previous: Jeff KingNext: Jeff King
Message 11 of 25 in “Documentation: XSLT/asciidoc.conf cleanup; tty literals”
  1. 0/8 Documentation: XSLT/asciidoc.conf cleanup; tty literalsChris Johnsen, Mar 24, 2009
  2. 1/8 Documentation: move callouts.xsl to manpage-{base,normal}.xslChris Johnsen, Mar 24, 2009
  3. Jeff KingMar 24, 2009
  4. Chris JohnsenMar 24, 2009
  5. Jeff KingMar 26, 2009
  6. 2/8 Documentation: use parametrized manpage-base.xsl with manpage-{1.72,normal}.xslChris Johnsen, Mar 24, 2009
  7. Jeff KingMar 24, 2009
  8. Chris JohnsenMar 24, 2009
  9. 3/8 Documentation: rename docbook-xsl-172 attribute to git-asciidoc-no-roffChris Johnsen, Mar 24, 2009
  10. Jeff KingMar 24, 2009
  11. Chris JohnsenMar 24, 2009
  12. Jeff KingMar 26, 2009
  13. Junio C HamanoMar 26, 2009
  14. Michael J GruberMar 26, 2009
  15. 4/8 Documentation: move quieting params into manpage-base.xslChris Johnsen, Mar 24, 2009
  16. Jeff KingMar 24, 2009
  17. 1/2 Documentation/Makefile: make most operations "quiet"Chris Johnsen, Mar 25, 2009
  18. 2/2 Documentation/Makefile: break up texi pipelineChris Johnsen, Mar 25, 2009
  19. Jeff KingMar 25, 2009
  20. Chris JohnsenMar 25, 2009
  21. 5/8 Documentation: move "spurious .sp" code into manpage-base.xslChris Johnsen, Mar 24, 2009
  22. 6/8 Documentation: asciidoc.conf: always use <literallayout> for [blocktext]Chris Johnsen, Mar 24, 2009
  23. 7/8 Documentation: asciidoc.conf: fix verse block with block titlesChris Johnsen, Mar 24, 2009
  24. 8/8 Documentation: option to render literal text as bold for manpagesChris Johnsen, Mar 24, 2009
  25. Junio C HamanoMar 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.