git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] Documentation/Makefile: break up texi pipeline

From
Chris Johnsen <chris_johnsen@pobox.com>
Date
Mar 25, 2009, 04:21 UTC
Message-ID
<1237954900-21161-2-git-send-email-chris_johnsen@pobox.com>
In-Reply-To
<1237954900-21161-1-git-send-email-chris_johnsen@pobox.com>

Most shells define the exit value of a pipeline as the exit value of the last process. For each texi rule, run the DOCBOOK2X_TEXI tool and the "fixup" script in their own non-pipeline commands so that make will notice an error exit code.

Signed-off-by: Chris Johnsen <chris_johnsen@pobox.com>
---
This textually depends on my "quiet doc gen" patch as it modifies
a couple of the same lines.
---
 Documentation/Makefile |   11 +++++++----
 1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index 3f9bc01..372a2cc 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -177,7 +177,7 @@ cmd-list.made: cmd-list.perl ../command-list.txt $(MAN1_TXT)
 
 clean:
 	$(RM) *.xml *.xml+ *.html *.html+ *.1 *.5 *.7
-	$(RM) *.texi *.texi+ git.info gitman.info
+	$(RM) *.texi *.texi+ *.texi++ git.info gitman.info
 	$(RM) howto-index.txt howto/*.html doc.dep
 	$(RM) technical/api-*.html technical/api-index.txt
 	$(RM) $(cmds_txt) *.made
@@ -220,8 +220,9 @@ git.info: user-manual.texi
 
 user-manual.texi: user-manual.xml
 	$(QUIET_DB2TEXI)$(RM) $@+ $@ && \
-	$(DOCBOOK2X_TEXI) user-manual.xml --encoding=UTF-8 --to-stdout | \
-		$(PERL_PATH) fix-texi.perl >$@+ && \
+	$(DOCBOOK2X_TEXI) user-manual.xml --encoding=UTF-8 --to-stdout >$@++ && \
+	$(PERL_PATH) fix-texi.perl <$@++ >$@+ && \
+	rm $@++ && \
 	mv $@+ $@
 
 user-manual.pdf: user-manual.xml
@@ -232,7 +233,9 @@ user-manual.pdf: user-manual.xml
 gitman.texi: $(MAN_XML) cat-texi.perl
 	$(QUIET_DB2TEXI)$(RM) $@+ $@ && \
 	($(foreach xml,$(MAN_XML),$(DOCBOOK2X_TEXI) --encoding=UTF-8 \
-		--to-stdout $(xml);)) | $(PERL_PATH) cat-texi.perl $@ >$@+ && \
+		--to-stdout $(xml) &&) true) > $@++
+	$(PERL_PATH) cat-texi.perl $@ <$@++ >$@+ && \
+	rm $@++ && \
 	mv $@+ $@
 
 gitman.info: gitman.texi
-- 
1.6.2.1.315.g33192
Previous: Chris JohnsenNext: Jeff King
Message 18 of 25 in “Documentation: XSLT/asciidoc.conf cleanup; tty literals”
  1. 0/8 Documentation: XSLT/asciidoc.conf cleanup; tty literalsChris Johnsen, Mar 24, 2009
  2. 1/8 Documentation: move callouts.xsl to manpage-{base,normal}.xslChris Johnsen, Mar 24, 2009
  3. Jeff KingMar 24, 2009
  4. Chris JohnsenMar 24, 2009
  5. Jeff KingMar 26, 2009
  6. 2/8 Documentation: use parametrized manpage-base.xsl with manpage-{1.72,normal}.xslChris Johnsen, Mar 24, 2009
  7. Jeff KingMar 24, 2009
  8. Chris JohnsenMar 24, 2009
  9. 3/8 Documentation: rename docbook-xsl-172 attribute to git-asciidoc-no-roffChris Johnsen, Mar 24, 2009
  10. Jeff KingMar 24, 2009
  11. Chris JohnsenMar 24, 2009
  12. Jeff KingMar 26, 2009
  13. Junio C HamanoMar 26, 2009
  14. Michael J GruberMar 26, 2009
  15. 4/8 Documentation: move quieting params into manpage-base.xslChris Johnsen, Mar 24, 2009
  16. Jeff KingMar 24, 2009
  17. 1/2 Documentation/Makefile: make most operations "quiet"Chris Johnsen, Mar 25, 2009
  18. 2/2 Documentation/Makefile: break up texi pipelineChris Johnsen, Mar 25, 2009
  19. Jeff KingMar 25, 2009
  20. Chris JohnsenMar 25, 2009
  21. 5/8 Documentation: move "spurious .sp" code into manpage-base.xslChris Johnsen, Mar 24, 2009
  22. 6/8 Documentation: asciidoc.conf: always use <literallayout> for [blocktext]Chris Johnsen, Mar 24, 2009
  23. 7/8 Documentation: asciidoc.conf: fix verse block with block titlesChris Johnsen, Mar 24, 2009
  24. 8/8 Documentation: option to render literal text as bold for manpagesChris Johnsen, Mar 24, 2009
  25. Junio C HamanoMar 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.