Re: [PATCH 4/8] Documentation: move quieting params into manpage-base.xsl
- From
Jeff King <peff@peff.net>
- Date
- Mar 24, 2009, 09:18 UTC
- Message-ID
- <20090324091836.GD1799@coredump.intra.peff.net>
- In-Reply-To
- <1237881866-5497-5-git-send-email-chris_johnsen@pobox.com>
On Tue, Mar 24, 2009 at 03:04:22AM -0500, Chris Johnsen wrote:
> I am not sure why these were only in the -1.72 variant. They > should probably be in -base (done by this patch) or in neither > variant. If there is a good reason for having it only in -1.72, > this patch can be dropped entirely, the rest do not depend on it.
Digging through the archive, it is hard to say. The original patch mentions DOCBOOK_XSL_172 as if callouts.xsl were already doing this, but I don't see any evidence that it ever did.
Definitely an improvement, IMHO. I wonder if we also want to consider making the "make" output a little nicer to Documentation/Makefile, similar to how the main Makefiles just prints "CC".
-Peff