Re: [PATCH 07/12] ll-merge: make flag easier to populate

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Aug 5, 2010, 13:05 UTC
Message-ID: <AANLkTinz2hbbYcq=cQ=wmkK+Kg5W6Xf4r8yjYp1211ZU@mail.gmail.com>
In-Reply-To: <20100805121658.GA23334@burratino>

On Thu, Aug 5, 2010 at 14:16, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 19 quoted lines

> Bert Wesarg wrote:
>> On Thu, Aug 5, 2010 at 13:17, Jonathan Nieder <jrnieder@gmail.com> wrote:
>
>>> +static inline int ll_opt_favor(int flag)
>>> +{
>>> +       return (flag & LL_OPT_FAVOR_MASK) >> LL_OPT_FAVOR_SHIFT;
>>> +}
>>> +
>>> +static inline int create_ll_flag(int favor)
>>> +{
>>> +       return ((favor << LL_OPT_FAVOR_SHIFT) & LL_OPT_FAVOR_MASK);
>>> +}
>>> +
> [...]
>> Or flavor_to_ll_flag()
>> and ll_flag_to_flavor().
>
> Sounds reasonable.  (Well, except this is “favor” as in “favor our
> side” or “favor their side” rather than “flavor of the month”.)  Patch?

Sorry for this typo. Do you really want a squash patch for this renaming?

Bert