Re: [PATCH 07/12] ll-merge: make flag easier to populate
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Aug 5, 2010, 12:16 UTC
- Message-ID
- <20100805121658.GA23334@burratino>
- In-Reply-To
- <AANLkTi=9GwZgiQHpBLN_L14==Pir0Gs=DosZHF4wg9zi@mail.gmail.com>
Bert Wesarg wrote:
> On Thu, Aug 5, 2010 at 13:17, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 10 quoted lines
>> +static inline int ll_opt_favor(int flag)
>> +{
>> + return (flag & LL_OPT_FAVOR_MASK) >> LL_OPT_FAVOR_SHIFT;
>> +}
>> +
>> +static inline int create_ll_flag(int favor)
>> +{
>> + return ((favor << LL_OPT_FAVOR_SHIFT) & LL_OPT_FAVOR_MASK);
>> +}
>> +[...]
> Or flavor_to_ll_flag() > and ll_flag_to_flavor().
Sounds reasonable. (Well, except this is “favor” as in “favor our side” or “favor their side” rather than “flavor of the month”.) Patch?