git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [msysGit] Re: [PATCH v4 02/15] mingw: implement syslog

From
Pat Thoyts <patthoyts@gmail.com>
Date
Oct 13, 2010, 21:17 UTC
Message-ID
<AANLkTinj21hnpsHR49nS0u_FtpwA=2Q7ygNpowufRoDC@mail.gmail.com>
In-Reply-To
<4CB60743.2030908@sunshineco.com>
On 13 October 2010 20:23, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 32 quoted lines
> On 10/13/2010 08:36 AM, Erik Faye-Lund wrote:
>>
>> On Tue, Oct 12, 2010 at 12:37 AM, Jonathan Nieder<jrnieder@gmail.com>
>>  wrote:
>>>
>>> Erik Faye-Lund wrote:
>>>
>>>> The string gets inlined into itself (with a limit of 100 expansions)
>>>> leading to string like "foo %1 bar" becoming "foo foo foo ... foo %1
>>>> bar bar bar ... bar". With our expansion, it becomes "foo % 1 bar"
>>>> instead.
>>>
>>> Ah, ok.  Sounds like there is no need to worry about requests for "%%1"
>>> etc.  Thanks for explaining.
>>>
>> Actually, %%1 is a bit of a tricky one. It seems that %%1 is used to
>> escape %1 on Windows 7, but not on earlier Windows version. I did test
>> this on Vista an XP earlier, but I'll re-test again later and report
>> back, in case my earlier tests were flawed.
>
> If that worked universally, escaping '%1' to '%%1' certainly would be nicer
> than '% 1'. (More generally, escape '%n' to '%%n', where n is a number.) It
> also would simplify the log message.
>
>> Can %%1 occur in an IPv6 address at all? If not, I'm tempted to not
>> handle it (unless it turns out I was wrong about %%1-escaping on Vista
>> and XP).
>
> According to sources I have studied, %%1 would be unlikely (or perhaps
> invalid) in IPv6 addresses.
>
> http://en.wikipedia.org/wiki/IPv6_address#Link-local_addresses_and_zone_indices
Not on windows. Try ipconfig:
   Link-local IPv6 Address . . . . . : fe80::c9fb:7840:66f5:b2e9%13
   Default Gateway . . . . . . . . . : fe80::20c:76ff:fe1e:e00%11
and so on. Its an interface fragment or something.

However - we really don't care. You can just substitute these to spaces and no-one will care. Keep it simple.

Previous: Eric SunshineNext: Erik Faye-Lund
Message 10 of 47 in “daemon-win32”
  1. 00/15 daemon-win32Erik Faye-Lund, Oct 11, 2010
  2. 01/15 mingw: add network-wrappers for daemonErik Faye-Lund, Oct 11, 2010
  3. Jonathan NiederOct 11, 2010
  4. 02/15 mingw: implement syslogErik Faye-Lund, Oct 11, 2010
  5. Jonathan NiederOct 11, 2010
  6. Erik Faye-LundOct 11, 2010
  7. Jonathan NiederOct 11, 2010
  8. Erik Faye-LundOct 13, 2010
  9. Eric SunshineOct 13, 2010
  10. Pat ThoytsOct 13, 2010
  11. Erik Faye-LundOct 14, 2010
  12. 03/15 compat: add inet_pton and inet_ntop prototypesErik Faye-Lund, Oct 11, 2010
  13. 04/15 inet_ntop: fix a couple of old-style declsErik Faye-Lund, Oct 11, 2010
  14. 05/15 mingw: use real pidErik Faye-Lund, Oct 11, 2010
  15. 06/15 mingw: support waitpid with pid > 0 and WNOHANGErik Faye-Lund, Oct 11, 2010
  16. 07/15 mingw: add kill emulationErik Faye-Lund, Oct 11, 2010
  17. 08/15 daemon: use run-command api for async servingErik Faye-Lund, Oct 11, 2010
  18. Junio C HamanoOct 13, 2010
  19. Erik Faye-LundOct 14, 2010
  20. Junio C HamanoOct 17, 2010
  21. 09/15 daemon: use full buffered mode for stderrErik Faye-Lund, Oct 11, 2010
  22. 10/15 Improve the mingw getaddrinfo stub to handle more use casesErik Faye-Lund, Oct 11, 2010
  23. 11/15 daemon: report connection from root-processErik Faye-Lund, Oct 11, 2010
  24. Junio C HamanoOct 13, 2010
  25. Erik Faye-LundOct 14, 2010
  26. Junio C HamanoOct 17, 2010
  27. Erik Faye-LundOct 17, 2010
  28. 12/15 mingw: import poll-emulation from gnulibErik Faye-Lund, Oct 11, 2010
  29. 13/15 mingw: use poll-emulation from gnulibErik Faye-Lund, Oct 11, 2010
  30. 14/15 daemon: use socklen_tErik Faye-Lund, Oct 11, 2010
  31. 15/15 daemon: opt-out on features that require posixErik Faye-Lund, Oct 11, 2010
  32. Junio C HamanoOct 13, 2010
  33. Erik Faye-LundOct 14, 2010
  34. Junio C HamanoOct 15, 2010
  35. Erik Faye-LundOct 18, 2010
  36. Jonathan NiederOct 18, 2010
  37. Andreas SchwabOct 18, 2010
  38. empty structsJonathan Nieder, Oct 18, 2010
  39. Erik Faye-LundOct 21, 2010
  40. Erik Faye-LundOct 21, 2010
  41. Jonathan NiederOct 21, 2010
  42. Erik Faye-LundOct 21, 2010
  43. Junio C HamanoOct 21, 2010
  44. Junio C HamanoOct 18, 2010
  45. Erik Faye-LundOct 21, 2010
  46. Jonathan NiederOct 21, 2010
  47. Erik Faye-LundOct 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.