Re: [PATCH v4 08/15] daemon: use run-command api for async serving

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 13, 2010, 22:47 UTC
Message-ID: <7vpqvdhfra.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1286833829-5116-9-git-send-email-kusmabite@gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

Show 26 quoted lines

> @@ -1017,7 +1005,12 @@ int main(int argc, char **argv)
>  				continue;
>  			}
>  		}
> +		if (!strcmp(arg, "--serve")) {
> +			serve_mode = 1;
> +			continue;
> +		}
>  		if (!strcmp(arg, "--inetd")) {
> +			serve_mode = 1;
>  			inetd_mode = 1;
>  			log_syslog = 1;
>  			continue;
> @@ -1161,12 +1154,12 @@ int main(int argc, char **argv)
>  		die("base-path '%s' does not exist or is not a directory",
>  		    base_path);
>  
> -	if (inetd_mode) {
> +	if (serve_mode) {
>  		struct sockaddr_storage ss;
>  		struct sockaddr *peer = (struct sockaddr *)&ss;
>  		socklen_t slen = sizeof(ss);
>  
> -		if (!freopen("/dev/null", "w", stderr))
> +		if (inetd_mode && !freopen("/dev/null", "w", stderr))
>  			die_errno("failed to redirect stderr to /dev/null");

This is not particularly a good style. Please make it more clear that we freopen in inetd mode by writing it like this:

	if (inetd_mode) {
        	if (!freopen(...))
                	die_errno(...)
	}